Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/api/variables.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method varController.listRaw has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *varController) listRaw(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
Severity: Minor
Found in pkg/api/variables.go - About 1 hr to fix

    Method varController.list has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (e *varController) list(w http.ResponseWriter, r *http.Request) {
    // handle raw var read.
    if r.URL.Query().Get("raw") == "true" {
        e.listRaw(w, r)
        return
    Severity: Minor
    Found in pkg/api/variables.go - About 1 hr to fix

      Method varController.listRaw has 7 return statements (exceeds 4 allowed).
      Open

      func (e *varController) listRaw(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
      Severity: Major
      Found in pkg/api/variables.go - About 45 mins to fix

        Method varController.update has 6 return statements (exceeds 4 allowed).
        Open

        func (e *varController) update(w http.ResponseWriter, r *http.Request) {
    id, err := uuid.Parse(chi.URLParam(r, "variableID"))
    if err != nil {
        writeError(w, &Error{
            Code:    "request_data_invalid",
        Severity: Major
        Found in pkg/api/variables.go - About 40 mins to fix

          Method varController.create has 6 return statements (exceeds 4 allowed).
          Open

          func (e *varController) create(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
          Severity: Major
          Found in pkg/api/variables.go - About 40 mins to fix

            Method varController.getRaw has 5 return statements (exceeds 4 allowed).
            Open

            func (e *varController) getRaw(w http.ResponseWriter, r *http.Request) {
    id, err := uuid.Parse(chi.URLParam(r, "variableID"))
    if err != nil {
        w.WriteHeader(http.StatusBadRequest)
        return
            Severity: Major
            Found in pkg/api/variables.go - About 35 mins to fix

              Method varController.list has 5 return statements (exceeds 4 allowed).
              Open

              func (e *varController) list(w http.ResponseWriter, r *http.Request) {
    // handle raw var read.
    if r.URL.Query().Get("raw") == "true" {
        e.listRaw(w, r)
        return
              Severity: Major
              Found in pkg/api/variables.go - About 35 mins to fix

                Method varController.get has 5 return statements (exceeds 4 allowed).
                Open

                func (e *varController) get(w http.ResponseWriter, r *http.Request) {
    // handle raw var read.
    if r.URL.Query().Get("raw") == "true" {
        e.getRaw(w, r)
        return
                Severity: Major
                Found in pkg/api/variables.go - About 35 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                  func (e *varController) mountRouter(r chi.Router) {
    r.Get("/{variableID}", e.get)
    r.Delete("/{variableID}", e.delete)
    r.Patch("/{variableID}", e.update)
                  Severity: Major
                  Found in pkg/api/variables.go and 2 other locations - About 40 mins to fix
                  pkg/api/namespaces.go on lines 24..31
                  pkg/api/secrets.go on lines 17..24

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 110.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status