Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/datastore/datastoresql/eventstore_history.go

Summary

Maintainability
A
1 hr
Test Coverage

Method sqlEventHistoryStore.GetStartingIDUntilTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (hs *sqlEventHistoryStore) GetStartingIDUntilTime(ctx context.Context, namespace string, lastID int, t time.Time, keyAndValues ...string) ([]*datastore.Event, error) {
Severity: Minor
Found in pkg/datastore/datastoresql/eventstore_history.go - About 35 mins to fix

    Method sqlEventHistoryStore.getEventsWithWhereClause has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (hs *sqlEventHistoryStore) getEventsWithWhereClause(ctx context.Context, namespace string, t time.Time, whereClause string, keyAndValues ...string) ([]*datastore.Event, error) {
    Severity: Minor
    Found in pkg/datastore/datastoresql/eventstore_history.go - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (hs *sqlEventHistoryStore) DeleteOld(ctx context.Context, sinceWhen time.Time) error {
    q := "DELETE FROM events_history WHERE received_at < $1;"
    tx := hs.db.WithContext(ctx).Exec(q, sinceWhen)
    if tx.Error != nil {
        return tx.Error
      Severity: Minor
      Found in pkg/datastore/datastoresql/eventstore_history.go and 2 other locations - About 30 mins to fix
      pkg/datastore/datastoresql/eventstore_listener.go on lines 98..106
      pkg/datastore/datastoresql/eventstore_topic.go on lines 52..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status