Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/datastore/datastoresql/runtime_variables.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method sqlRuntimeVariablesStore.Set has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *sqlRuntimeVariablesStore) Set(ctx context.Context, variable *datastore.RuntimeVariable) (*datastore.RuntimeVariable, error) {
    if variable.Name == "" {
        return nil, datastore.ErrInvalidRuntimeVariableName
    }
    if matched, _ := regexp.MatchString(datastore.RuntimeVariableNameRegexPattern, variable.Name); !matched {
Severity: Minor
Found in pkg/datastore/datastoresql/runtime_variables.go - About 1 hr to fix

    Method sqlRuntimeVariablesStore.Set has 11 return statements (exceeds 4 allowed).
    Open

    func (s *sqlRuntimeVariablesStore) Set(ctx context.Context, variable *datastore.RuntimeVariable) (*datastore.RuntimeVariable, error) {
    if variable.Name == "" {
        return nil, datastore.ErrInvalidRuntimeVariableName
    }
    if matched, _ := regexp.MatchString(datastore.RuntimeVariableNameRegexPattern, variable.Name); !matched {
    Severity: Major
    Found in pkg/datastore/datastoresql/runtime_variables.go - About 1 hr to fix

      Method sqlRuntimeVariablesStore.Patch has 6 return statements (exceeds 4 allowed).
      Open

      func (s *sqlRuntimeVariablesStore) Patch(ctx context.Context, id uuid.UUID, patch *datastore.RuntimeVariablePatch) (*datastore.RuntimeVariable, error) {
    if patch.Name != nil {
        if *patch.Name == "" {
            return nil, datastore.ErrInvalidRuntimeVariableName
        }
      Severity: Major
      Found in pkg/datastore/datastoresql/runtime_variables.go - About 40 mins to fix

        Method sqlRuntimeVariablesStore.Create has 6 return statements (exceeds 4 allowed).
        Open

        func (s *sqlRuntimeVariablesStore) Create(ctx context.Context, variable *datastore.RuntimeVariable) (*datastore.RuntimeVariable, error) {
    if variable.Name == "" {
        return nil, datastore.ErrInvalidRuntimeVariableName
    }
    if matched, _ := regexp.MatchString(datastore.RuntimeVariableNameRegexPattern, variable.Name); !matched {
        Severity: Major
        Found in pkg/datastore/datastoresql/runtime_variables.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (s *sqlRuntimeVariablesStore) GetByID(ctx context.Context, id uuid.UUID) (*datastore.RuntimeVariable, error) {
    variable := &datastore.RuntimeVariable{}
    res := s.db.WithContext(ctx).Raw(`
                            SELECT 
                                id, namespace, workflow_path, instance_id,
          Severity: Major
          Found in pkg/datastore/datastoresql/runtime_variables.go and 1 other location - About 1 hr to fix
          pkg/datastore/datastoresql/namespaces.go on lines 19..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (s *sqlRuntimeVariablesStore) Delete(ctx context.Context, id uuid.UUID) error {
    res := s.db.WithContext(ctx).Exec(
        `DELETE FROM runtime_variables WHERE id = ?`,
        id)
    if res.Error != nil {
          Severity: Minor
          Found in pkg/datastore/datastoresql/runtime_variables.go and 1 other location - About 35 mins to fix
          pkg/datastore/datastoresql/mirror.go on lines 130..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status