Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/filestore/filestoresql/root_query.go

Summary

Maintainability
C
1 day
Test Coverage

Method RootQuery.CreateFile has 69 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (q *RootQuery) CreateFile(ctx context.Context, path string, typ filestore.FileType, mimeType string, data []byte) (*filestore.File, error) {
    path, err := filestore.SanitizePath(path)
    if err != nil {
        return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
    }
Severity: Minor
Found in pkg/filestore/filestoresql/root_query.go - About 1 hr to fix

    Method RootQuery.CreateFile has 13 return statements (exceeds 4 allowed).
    Open

    func (q *RootQuery) CreateFile(ctx context.Context, path string, typ filestore.FileType, mimeType string, data []byte) (*filestore.File, error) {
    path, err := filestore.SanitizePath(path)
    if err != nil {
        return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
    }
    Severity: Major
    Found in pkg/filestore/filestoresql/root_query.go - About 1 hr to fix

      Method RootQuery.ReadDirectory has 6 return statements (exceeds 4 allowed).
      Open

      func (q *RootQuery) ReadDirectory(ctx context.Context, path string) ([]*filestore.File, error) {
    var list []*filestore.File
    path, err := filestore.SanitizePath(path)
    if err != nil {
        return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
      Severity: Major
      Found in pkg/filestore/filestoresql/root_query.go - About 40 mins to fix

        Method RootQuery.checkRootExists has 6 return statements (exceeds 4 allowed).
        Open

        func (q *RootQuery) checkRootExists(ctx context.Context) error {
    zeroUUID := (uuid.UUID{}).String()

    if zeroUUID == q.rootID.String() {
        n := &filestore.Root{}
        Severity: Major
        Found in pkg/filestore/filestoresql/root_query.go - About 40 mins to fix

          Method RootQuery.GetFile has 6 return statements (exceeds 4 allowed).
          Open

          func (q *RootQuery) GetFile(ctx context.Context, path string) (*filestore.File, error) {
    path, err := filestore.SanitizePath(path)
    if err != nil {
        return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
    }
          Severity: Major
          Found in pkg/filestore/filestoresql/root_query.go - About 40 mins to fix

            Method RootQuery.CreateFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (q *RootQuery) CreateFile(ctx context.Context, path string, typ filestore.FileType, mimeType string, data []byte) (*filestore.File, error) {
            Severity: Minor
            Found in pkg/filestore/filestoresql/root_query.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (q *RootQuery) ListAllFiles(ctx context.Context) ([]*filestore.File, error) {
    var list []*filestore.File

    // check if root exists.
    if err := q.checkRootExists(ctx); err != nil {
              Severity: Major
              Found in pkg/filestore/filestoresql/root_query.go and 1 other location - About 1 hr to fix
              pkg/filestore/filestoresql/root_query.go on lines 55..74

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 158.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (q *RootQuery) ListDirektivFilesWithData(ctx context.Context) ([]*filestore.File, error) {
    var list []*filestore.File

    // check if root exists.
    if err := q.checkRootExists(ctx); err != nil {
              Severity: Major
              Found in pkg/filestore/filestoresql/root_query.go and 1 other location - About 1 hr to fix
              pkg/filestore/filestoresql/root_query.go on lines 33..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 158.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status