Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/flow/events.go

Summary

Maintainability
D
2 days
Test Coverage

File events.go has 525 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package flow

import (
    "context"
    "encoding/gob"
Severity: Minor
Found in pkg/flow/events.go - About 2 hrs to fix

    Method flow.EventHistoryStream has 76 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (flow *flow) EventHistoryStream(req *grpc.EventHistoryRequest, srv grpc.Flow_EventHistoryStreamServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
    var phash, nhash string
    Severity: Major
    Found in pkg/flow/events.go - About 2 hrs to fix

      Method events.handleEvent has 60 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (events *events) handleEvent(ctx context.Context, ns uuid.UUID, nsName string, ce *cloudevents.Event) error {
    span := trace.SpanFromContext(ctx)
    traceID := span.SpanContext().TraceID()
    spanID := span.SpanContext().SpanID()
    slog := *slog.With("trace", traceID, "span", spanID, "namespace", nsName)
      Severity: Minor
      Found in pkg/flow/events.go - About 1 hr to fix

        Method flow.EventHistory has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
        Open

        func (flow *flow) EventHistory(ctx context.Context, req *grpc.EventHistoryRequest) (*grpc.EventHistoryResponse, error) {
    slog.Debug("Handling gRPC request", "this", this())

    count := 0
    var res []*datastore.Event
        Severity: Minor
        Found in pkg/flow/events.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method flow.EventHistory has 56 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (flow *flow) EventHistory(ctx context.Context, req *grpc.EventHistoryRequest) (*grpc.EventHistoryResponse, error) {
    slog.Debug("Handling gRPC request", "this", this())

    count := 0
    var res []*datastore.Event
        Severity: Minor
        Found in pkg/flow/events.go - About 1 hr to fix

          Method flow.BroadcastCloudevent has 56 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (flow *flow) BroadcastCloudevent(ctx context.Context, in *grpc.BroadcastCloudeventRequest) (*emptypb.Empty, error) {
    slog.Debug("Handling gRPC request", "this", this())
    ctx, end := startIncomingEvent(ctx, "flow")
    defer end()
          Severity: Minor
          Found in pkg/flow/events.go - About 1 hr to fix

            Method flow.EventHistoryStream has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
            Open

            func (flow *flow) EventHistoryStream(req *grpc.EventHistoryRequest, srv grpc.Flow_EventHistoryStreamServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
    var phash, nhash string
            Severity: Minor
            Found in pkg/flow/events.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method events.handleEvent has 9 return statements (exceeds 4 allowed).
            Open

            func (events *events) handleEvent(ctx context.Context, ns uuid.UUID, nsName string, ce *cloudevents.Event) error {
    span := trace.SpanFromContext(ctx)
    traceID := span.SpanContext().TraceID()
    spanID := span.SpanContext().SpanID()
    slog := *slog.With("trace", traceID, "span", spanID, "namespace", nsName)
            Severity: Major
            Found in pkg/flow/events.go - About 55 mins to fix

              Method flow.EventHistoryStream has 8 return statements (exceeds 4 allowed).
              Open

              func (flow *flow) EventHistoryStream(req *grpc.EventHistoryRequest, srv grpc.Flow_EventHistoryStreamServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
    var phash, nhash string
              Severity: Major
              Found in pkg/flow/events.go - About 50 mins to fix

                Method flow.BroadcastCloudevent has 8 return statements (exceeds 4 allowed).
                Open

                func (flow *flow) BroadcastCloudevent(ctx context.Context, in *grpc.BroadcastCloudeventRequest) (*emptypb.Empty, error) {
    slog.Debug("Handling gRPC request", "this", this())
    ctx, end := startIncomingEvent(ctx, "flow")
    defer end()
                Severity: Major
                Found in pkg/flow/events.go - About 50 mins to fix

                  Method flow.EventListenersStream has 7 return statements (exceeds 4 allowed).
                  Open

                  func (flow *flow) EventListenersStream(req *grpc.EventListenersRequest, srv grpc.Flow_EventListenersStreamServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
    var phash, nhash string
                  Severity: Major
                  Found in pkg/flow/events.go - About 45 mins to fix

                    Method flow.HistoricalEvent has 6 return statements (exceeds 4 allowed).
                    Open

                    func (flow *flow) HistoricalEvent(ctx context.Context, in *grpc.HistoricalEventRequest) (*grpc.HistoricalEventResponse, error) {
    slog.Debug("Handling gRPC request", "this", this())

    eid := in.GetId()
    if eid == "" {
                    Severity: Major
                    Found in pkg/flow/events.go - About 40 mins to fix

                      Method flow.EventHistory has 6 return statements (exceeds 4 allowed).
                      Open

                      func (flow *flow) EventHistory(ctx context.Context, req *grpc.EventHistoryRequest) (*grpc.EventHistoryResponse, error) {
    slog.Debug("Handling gRPC request", "this", this())

    count := 0
    var res []*datastore.Event
                      Severity: Major
                      Found in pkg/flow/events.go - About 40 mins to fix

                        Method flow.ReplayEvent has 6 return statements (exceeds 4 allowed).
                        Open

                        func (flow *flow) ReplayEvent(ctx context.Context, req *grpc.ReplayEventRequest) (*emptypb.Empty, error) {
    slog.Debug("Handling gRPC request", "this", this())

    eid := req.GetId()
    if eid == "" {
                        Severity: Major
                        Found in pkg/flow/events.go - About 40 mins to fix

                          Method flow.EventListeners has 5 return statements (exceeds 4 allowed).
                          Open

                          func (flow *flow) EventListeners(ctx context.Context, req *grpc.EventListenersRequest) (*grpc.EventListenersResponse, error) {
    slog.Debug("Handling gRPC request", "this", this())

    var resListeners []*datastore.EventListener
    var ns *datastore.Namespace
                          Severity: Major
                          Found in pkg/flow/events.go - About 35 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                err = flow.runSQLTx(ctx, func(tx *database.SQLStore) error {
        ns, err = tx.DataStore().Namespaces().GetByName(ctx, in.GetNamespace())
        if err != nil {
            return err
        }
                            Severity: Major
                            Found in pkg/flow/events.go and 1 other location - About 1 hr to fix
                            pkg/flow/events.go on lines 508..521

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 133.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                err = flow.runSQLTx(ctx, func(tx *database.SQLStore) error {
        ns, err = tx.DataStore().Namespaces().GetByName(ctx, req.GetNamespace())
        if err != nil {
            return err
        }
                            Severity: Major
                            Found in pkg/flow/events.go and 1 other location - About 1 hr to fix
                            pkg/flow/events.go on lines 302..314

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 133.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status