Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/flow/grpc-internal.go

Summary

Maintainability
C
1 day
Test Coverage

Method internal.FileVariableParcels has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (internal *internal) FileVariableParcels(req *grpc.VariableInternalRequest, srv grpc.Internal_FileVariableParcelsServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
Severity: Minor
Found in pkg/flow/grpc-internal.go - About 1 hr to fix

    Method internal.FileVariableParcels has 7 return statements (exceeds 4 allowed).
    Open

    func (internal *internal) FileVariableParcels(req *grpc.VariableInternalRequest, srv grpc.Internal_FileVariableParcelsServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    ctx := srv.Context()
    Severity: Major
    Found in pkg/flow/grpc-internal.go - About 45 mins to fix

      Method internal.getInstance has 5 return statements (exceeds 4 allowed).
      Open

      func (internal *internal) getInstance(ctx context.Context, instanceID string) (*enginerefactor.Instance, error) {
    id, err := uuid.Parse(instanceID)
    if err != nil {
        return nil, err
    }
      Severity: Major
      Found in pkg/flow/grpc-internal.go - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (srv *setInstanceVariableParcelsTranslator) SendAndClose(resp *grpc.SetInstanceVariableResponse) error {
    var inst string
    if srv.inst != nil {
        inst = srv.inst.Instance.ID.String()
    }
        Severity: Major
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 1 hr to fix
        pkg/flow/grpc-internal.go on lines 191..206
        pkg/flow/grpc-internal.go on lines 488..503

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 179.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (srv *setWorkflowVariableParcelsTranslator) SendAndClose(resp *grpc.SetWorkflowVariableResponse) error {
    var inst string
    if srv.inst != nil {
        inst = srv.inst.Instance.ID.String()
    }
        Severity: Major
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 1 hr to fix
        pkg/flow/grpc-internal.go on lines 318..333
        pkg/flow/grpc-internal.go on lines 488..503

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 179.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (srv *setNamespaceVariableParcelsTranslator) SendAndClose(resp *grpc.SetNamespaceVariableResponse) error {
    var inst string
    if srv.inst != nil {
        inst = srv.inst.Instance.ID.String()
    }
        Severity: Major
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 1 hr to fix
        pkg/flow/grpc-internal.go on lines 191..206
        pkg/flow/grpc-internal.go on lines 318..333

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 179.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (internal *internal) SetNamespaceVariableParcels(srv grpc.Internal_SetNamespaceVariableParcelsServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    fsrv := &setNamespaceVariableParcelsTranslator{
        internal: internal,
        Severity: Minor
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 35 mins to fix
        pkg/flow/grpc-internal.go on lines 233..247
        pkg/flow/grpc-internal.go on lines 360..374

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (internal *internal) SetWorkflowVariableParcels(srv grpc.Internal_SetWorkflowVariableParcelsServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    fsrv := &setWorkflowVariableParcelsTranslator{
        internal: internal,
        Severity: Minor
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 35 mins to fix
        pkg/flow/grpc-internal.go on lines 360..374
        pkg/flow/grpc-internal.go on lines 529..543

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (internal *internal) SetInstanceVariableParcels(srv grpc.Internal_SetInstanceVariableParcelsServer) error {
    slog.Debug("Handling gRPC request", "this", this())

    fsrv := &setInstanceVariableParcelsTranslator{
        internal: internal,
        Severity: Minor
        Found in pkg/flow/grpc-internal.go and 2 other locations - About 35 mins to fix
        pkg/flow/grpc-internal.go on lines 233..247
        pkg/flow/grpc-internal.go on lines 529..543

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status