Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/flow/instance_messages.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method engine.handleInstanceMessage has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (engine *engine) handleInstanceMessage(ctx context.Context, im *instanceMemory, msg *instancestore.InstanceMessageData) *states.Transition {
    instanceCtx := tracing.AddInstanceMemoryAttr(ctx,
        tracing.InstanceAttributes{
            Namespace:    im.Namespace().Name,
            InstanceID:   im.GetInstanceID().String(),
Severity: Minor
Found in pkg/flow/instance_messages.go - About 1 hr to fix

    Method engine.enqueueInstanceMessage has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (engine *engine) enqueueInstanceMessage(ctx context.Context, id uuid.UUID, kind string, data interface{}) error {
    // TODO: should this add state and step data? At some point these fields died so I have removed them.
    payload, err := json.Marshal(map[string]interface{}{
        "type": kind,
        "data": data,
    Severity: Minor
    Found in pkg/flow/instance_messages.go - About 1 hr to fix

      Method engine.enqueueInstanceMessage has 7 return statements (exceeds 4 allowed).
      Open

      func (engine *engine) enqueueInstanceMessage(ctx context.Context, id uuid.UUID, kind string, data interface{}) error {
    // TODO: should this add state and step data? At some point these fields died so I have removed them.
    payload, err := json.Marshal(map[string]interface{}{
        "type": kind,
        "data": data,
      Severity: Major
      Found in pkg/flow/instance_messages.go - About 45 mins to fix

        Method engine.handleInstanceMessage has 5 return statements (exceeds 4 allowed).
        Open

        func (engine *engine) handleInstanceMessage(ctx context.Context, im *instanceMemory, msg *instancestore.InstanceMessageData) *states.Transition {
    instanceCtx := tracing.AddInstanceMemoryAttr(ctx,
        tracing.InstanceAttributes{
            Namespace:    im.Namespace().Name,
            InstanceID:   im.GetInstanceID().String(),
        Severity: Major
        Found in pkg/flow/instance_messages.go - About 35 mins to fix

          Similar blocks of code found in 9 locations. Consider refactoring.
          Open

              instanceCtx := tracing.AddInstanceMemoryAttr(ctx,
        tracing.InstanceAttributes{
            Namespace:    im.Namespace().Name,
            InstanceID:   im.GetInstanceID().String(),
            Invoker:      im.instance.Instance.Invoker,
          Severity: Major
          Found in pkg/flow/instance_messages.go and 8 other locations - About 50 mins to fix
          pkg/flow/engine.go on lines 384..392
          pkg/flow/engine.go on lines 540..547
          pkg/flow/engine.go on lines 672..679
          pkg/flow/engine.go on lines 951..958
          pkg/flow/engine.go on lines 968..975
          pkg/flow/scheduling.go on lines 105..112
          pkg/flow/status.go on lines 48..55
          pkg/flow/temporary.go on lines 135..142

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status