Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/flow/states/parallel.go

Summary

Maintainability
D
1 day
Test Coverage

Method parallelLogic.processActionResults has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring.
Open

func (logic *parallelLogic) processActionResults(ctx context.Context, children []*ChildInfo, results *actionResultPayload) (*Transition, error) {
    var err error

    var found bool
    var idx int
Severity: Minor
Found in pkg/flow/states/parallel.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parallelLogic.processActionResults has 120 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (logic *parallelLogic) processActionResults(ctx context.Context, children []*ChildInfo, results *actionResultPayload) (*Transition, error) {
    var err error

    var found bool
    var idx int
Severity: Major
Found in pkg/flow/states/parallel.go - About 3 hrs to fix

    Method parallelLogic.processActionResults has 18 return statements (exceeds 4 allowed).
    Open

    func (logic *parallelLogic) processActionResults(ctx context.Context, children []*ChildInfo, results *actionResultPayload) (*Transition, error) {
    var err error

    var found bool
    var idx int
    Severity: Major
    Found in pkg/flow/states/parallel.go - About 1 hr to fix

      Method parallelLogic.Run has 7 return statements (exceeds 4 allowed).
      Open

      func (logic *parallelLogic) Run(ctx context.Context, wakedata []byte) (*Transition, error) {
    // first schedule
    if len(wakedata) == 0 {
        err := noMemory(logic)
        if err != nil {
      Severity: Major
      Found in pkg/flow/states/parallel.go - About 45 mins to fix

        Method parallelLogic.scheduleAction has 6 return statements (exceeds 4 allowed).
        Open

        func (logic *parallelLogic) scheduleAction(ctx context.Context, action *model.ActionDefinition, attempt int) (*ChildInfo, error) {
    input, files, err := generateActionInput(ctx, &generateActionInputArgs{
        Instance: logic.Instance,
        Source:   logic.GetInstanceData(),
        Action:   action,
        Severity: Major
        Found in pkg/flow/states/parallel.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (logic *parallelLogic) Deadline(ctx context.Context) time.Time {
    d, err := duration.ParseISO8601(logic.Timeout)
    if err != nil {
        if logic.Timeout != "" {
            logic.Log(ctx, log.Error, "failed to parse timeout: %v", err)
          Severity: Major
          Found in pkg/flow/states/parallel.go and 1 other location - About 1 hr to fix
          pkg/flow/states/foreach.go on lines 50..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 7 locations. Consider refactoring.
          Open

          func Parallel(instance Instance, state model.State) (Logic, error) {
    parallel, ok := state.(*model.ParallelState)
    if !ok {
        return nil, derrors.NewInternalError(errors.New("bad state object"))
    }
          Severity: Major
          Found in pkg/flow/states/parallel.go and 6 other locations - About 45 mins to fix
          pkg/flow/states/action.go on lines 31..42
          pkg/flow/states/delay.go on lines 26..37
          pkg/flow/states/error.go on lines 23..34
          pkg/flow/states/foreach.go on lines 35..46
          pkg/flow/states/noop.go on lines 22..33
          pkg/flow/states/switch.go on lines 24..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status