Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/flow/temporary.go

Summary

Maintainability
D
2 days
Test Coverage

File temporary.go has 550 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package flow

import (
    "context"
    "encoding/json"
Severity: Minor
Found in pkg/flow/temporary.go - About 3 hrs to fix

    Method instanceMemory.GetVariables has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
    Open

    func (im *instanceMemory) GetVariables(ctx context.Context, vars []states.VariableSelector) ([]states.Variable, error) {
    x := make([]states.Variable, 0)

    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
    Severity: Minor
    Found in pkg/flow/temporary.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method instanceMemory.SetVariables has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
    Open

    func (im *instanceMemory) SetVariables(ctx context.Context, vars []states.VariableSetter) error {
    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
        return err
    }
    Severity: Minor
    Found in pkg/flow/temporary.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method engine.doKnativeHTTPRequest has 88 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (engine *engine) doKnativeHTTPRequest(ctx context.Context,
    ar *functionRequest, arReq *enginerefactor.ActionRequest,
) {
    ctx, spanEnd, err := tracing.NewSpan(ctx, "executing knative request to action")
    if err != nil {
    Severity: Major
    Found in pkg/flow/temporary.go - About 2 hrs to fix

      Method engine.newIsolateRequest has 75 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (engine *engine) newIsolateRequest(im *instanceMemory, stateID string, timeout int,
    fn model.FunctionDefinition, inputData []byte,
    uid uuid.UUID, async bool, files []model.FunctionFileDefinition, iterator int,
) (*functionRequest, *enginerefactor.ActionRequest, error) {
    ar := new(functionRequest)
      Severity: Minor
      Found in pkg/flow/temporary.go - About 2 hrs to fix

        Method instanceMemory.GetVariables has 71 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (im *instanceMemory) GetVariables(ctx context.Context, vars []states.VariableSelector) ([]states.Variable, error) {
    x := make([]states.Variable, 0)

    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
        Severity: Minor
        Found in pkg/flow/temporary.go - About 1 hr to fix

          Method engine.doKnativeHTTPRequest has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
          Open

          func (engine *engine) doKnativeHTTPRequest(ctx context.Context,
    ar *functionRequest, arReq *enginerefactor.ActionRequest,
) {
    ctx, spanEnd, err := tracing.NewSpan(ctx, "executing knative request to action")
    if err != nil {
          Severity: Minor
          Found in pkg/flow/temporary.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method instanceMemory.SetVariables has 60 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (im *instanceMemory) SetVariables(ctx context.Context, vars []states.VariableSetter) error {
    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
        return err
    }
          Severity: Minor
          Found in pkg/flow/temporary.go - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                    if !(v.MIMEType == "text/plain; charset=utf-8" || v.MIMEType == "text/plain" || v.MIMEType == "application/octet-stream") && (d == "{}" || d == "[]" || d == "0" || d == `""` || d == "null") {
            Severity: Critical
            Found in pkg/flow/temporary.go - About 1 hr to fix

              Method engine.newIsolateRequest has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (engine *engine) newIsolateRequest(im *instanceMemory, stateID string, timeout int,
    fn model.FunctionDefinition, inputData []byte,
    uid uuid.UUID, async bool, files []model.FunctionFileDefinition, iterator int,
              Severity: Major
              Found in pkg/flow/temporary.go - About 1 hr to fix

                Method engine.doKnativeHTTPRequest has 8 return statements (exceeds 4 allowed).
                Open

                func (engine *engine) doKnativeHTTPRequest(ctx context.Context,
    ar *functionRequest, arReq *enginerefactor.ActionRequest,
) {
    ctx, spanEnd, err := tracing.NewSpan(ctx, "executing knative request to action")
    if err != nil {
                Severity: Major
                Found in pkg/flow/temporary.go - About 50 mins to fix

                  Method instanceMemory.SetVariables has 7 return statements (exceeds 4 allowed).
                  Open

                  func (im *instanceMemory) SetVariables(ctx context.Context, vars []states.VariableSetter) error {
    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
        return err
    }
                  Severity: Major
                  Found in pkg/flow/temporary.go - About 45 mins to fix

                    Method instanceMemory.GetVariables has 7 return statements (exceeds 4 allowed).
                    Open

                    func (im *instanceMemory) GetVariables(ctx context.Context, vars []states.VariableSelector) ([]states.Variable, error) {
    x := make([]states.Variable, 0)

    tx, err := im.engine.flow.beginSQLTx(ctx)
    if err != nil {
                    Severity: Major
                    Found in pkg/flow/temporary.go - About 45 mins to fix

                      Similar blocks of code found in 9 locations. Consider refactoring.
                      Open

                          ctx = tracing.AddInstanceMemoryAttr(ctx, tracing.InstanceAttributes{
        Namespace:    im.Namespace().Name,
        InstanceID:   im.GetInstanceID().String(),
        Invoker:      im.instance.Instance.Invoker,
        Callpath:     tracing.CreateCallpath(im.instance),
                      Severity: Major
                      Found in pkg/flow/temporary.go and 8 other locations - About 50 mins to fix
                      pkg/flow/engine.go on lines 384..392
                      pkg/flow/engine.go on lines 540..547
                      pkg/flow/engine.go on lines 672..679
                      pkg/flow/engine.go on lines 951..958
                      pkg/flow/engine.go on lines 968..975
                      pkg/flow/instance_messages.go on lines 118..128
                      pkg/flow/scheduling.go on lines 105..112
                      pkg/flow/status.go on lines 48..55

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 120.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status