Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/model/workflow.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method Workflow.validate has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (o *Workflow) validate() error {
    if len(o.States) == 0 {
        return errors.New("workflow has no defined states")
    }
Severity: Minor
Found in pkg/model/workflow.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Workflow.validate has 8 return statements (exceeds 4 allowed).
Open

func (o *Workflow) validate() error {
    if len(o.States) == 0 {
        return errors.New("workflow has no defined states")
    }
Severity: Major
Found in pkg/model/workflow.go - About 50 mins to fix

    Method Workflow.unmarshal has 8 return statements (exceeds 4 allowed).
    Open

    func (o *Workflow) unmarshal(m map[string]interface{}) error {
    // split start out from the rest, and umarshal it
    if err := o.unmStart(m); err != nil {
        return err
    }
    Severity: Major
    Found in pkg/model/workflow.go - About 50 mins to fix

      Method Workflow.unmStart has 5 return statements (exceeds 4 allowed).
      Open

      func (o *Workflow) unmStart(m map[string]interface{}) (err error) {
    // split start out from the rest
    y, startFound := m["start"]
    if startFound {
        // Start
      Severity: Major
      Found in pkg/model/workflow.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (o *Workflow) unmState(state interface{}, sIndex int) error {
    stateMap, stateType, err := processInterfaceMap(state)
    if err != nil {
        return fmt.Errorf("state[%d]: %w", sIndex, err)
    }
        Severity: Major
        Found in pkg/model/workflow.go and 1 other location - About 1 hr to fix
        pkg/model/workflow.go on lines 149..172

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (o *Workflow) unmFunction(state interface{}, fIndex int) error {
    fMap, fType, err := processInterfaceMap(state)
    if err != nil {
        return fmt.Errorf("function[%d]: %w", fIndex, err)
    }
        Severity: Major
        Found in pkg/model/workflow.go and 1 other location - About 1 hr to fix
        pkg/model/workflow.go on lines 124..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status