Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/refactor/api/instances.go

Summary

Maintainability
F
3 days
Test Coverage

File instances.go has 595 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package api

import (
    "bytes"
    "context"
Severity: Minor
Found in pkg/refactor/api/instances.go - About 4 hrs to fix

    Method instController.list has 105 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (e *instController) list(w http.ResponseWriter, r *http.Request) {
    ctx := r.Context()
    ns := extractContextNamespace(r)

    pagination, err := e.getPagination(r)
    Severity: Major
    Found in pkg/refactor/api/instances.go - About 3 hrs to fix

      Method instController.getPagination has 81 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (e *instController) getPagination(r *http.Request) (*paginationOptions, error) {
    opts := new(paginationOptions)

    x := r.URL.Query().Get("limit")
    if x != "" {
      Severity: Major
      Found in pkg/refactor/api/instances.go - About 2 hrs to fix

        Method instController.list has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *instController) list(w http.ResponseWriter, r *http.Request) {
    ctx := r.Context()
    ns := extractContextNamespace(r)

    pagination, err := e.getPagination(r)
        Severity: Minor
        Found in pkg/refactor/api/instances.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method instController.handleWait has 62 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (e *instController) handleWait(ctx context.Context, w http.ResponseWriter, r *http.Request, data *instancestore.InstanceData) {
    var err error

    id := data.ID
    dt := time.Millisecond * 100
        Severity: Minor
        Found in pkg/refactor/api/instances.go - About 1 hr to fix

          Method instController.getPagination has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
          Open

          func (e *instController) getPagination(r *http.Request) (*paginationOptions, error) {
    opts := new(paginationOptions)

    x := r.URL.Query().Get("limit")
    if x != "" {
          Severity: Minor
          Found in pkg/refactor/api/instances.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method instController.getPagination has 5 return statements (exceeds 4 allowed).
          Open

          func (e *instController) getPagination(r *http.Request) (*paginationOptions, error) {
    opts := new(paginationOptions)

    x := r.URL.Query().Get("limit")
    if x != "" {
          Severity: Major
          Found in pkg/refactor/api/instances.go - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            func (e *instController) input(w http.ResponseWriter, r *http.Request) {
    ctx := r.Context()
    ns := extractContextNamespace(r)
    instanceID := chi.URLParam(r, "instanceID")
            Severity: Major
            Found in pkg/refactor/api/instances.go and 2 other locations - About 3 hrs to fix
            pkg/refactor/api/instances.go on lines 161..199
            pkg/refactor/api/instances.go on lines 202..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 278.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            func (e *instController) output(w http.ResponseWriter, r *http.Request) {
    ctx := r.Context()
    ns := extractContextNamespace(r)
    instanceID := chi.URLParam(r, "instanceID")
            Severity: Major
            Found in pkg/refactor/api/instances.go and 2 other locations - About 3 hrs to fix
            pkg/refactor/api/instances.go on lines 120..158
            pkg/refactor/api/instances.go on lines 202..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 278.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            func (e *instController) metadata(w http.ResponseWriter, r *http.Request) {
    ctx := r.Context()
    ns := extractContextNamespace(r)
    instanceID := chi.URLParam(r, "instanceID")
            Severity: Major
            Found in pkg/refactor/api/instances.go and 2 other locations - About 3 hrs to fix
            pkg/refactor/api/instances.go on lines 120..158
            pkg/refactor/api/instances.go on lines 161..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 278.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status