Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/refactor/service/docker_client.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method dockerClient.createService has 92 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *dockerClient) createService(sv *core.ServiceFileData) error {
    // don't pull any image that has 'local' prefix.
    if !strings.HasPrefix(sv.Image, "local") {
        out, err := c.cli.ImagePull(context.Background(), sv.Image, types.ImagePullOptions{})
        if err != nil {
Severity: Major
Found in pkg/refactor/service/docker_client.go - About 2 hrs to fix

    Method dockerClient.createService has 7 return statements (exceeds 4 allowed).
    Open

    func (c *dockerClient) createService(sv *core.ServiceFileData) error {
    // don't pull any image that has 'local' prefix.
    if !strings.HasPrefix(sv.Image, "local") {
        out, err := c.cli.ImagePull(context.Background(), sv.Image, types.ImagePullOptions{})
        if err != nil {
    Severity: Major
    Found in pkg/refactor/service/docker_client.go - About 45 mins to fix

      Method dockerClient.cleanAll has 5 return statements (exceeds 4 allowed).
      Open

      func (c *dockerClient) cleanAll() error {
    containers, err := c.cli.ContainerList(context.Background(), types.ContainerListOptions{All: true})
    if err != nil {
        return err
    }
      Severity: Major
      Found in pkg/refactor/service/docker_client.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status