vorteil/direktiv

View on GitHub
ui/src/util/router/pages.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function usePages has 462 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const usePages = (): PageType & EnterprisePageType => {
  const enterprisePages: EnterprisePageType = isEnterprise()
    ? {
        permissions: {
          name: "components.mainMenu.permissions",
Severity: Major
Found in ui/src/util/router/pages.tsx - About 2 days to fix

    File pages.tsx has 691 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
      ActivitySquare,
      BadgeCheck,
      Boxes,
      FolderTree,
    Severity: Major
    Found in ui/src/util/router/pages.tsx - About 1 day to fix

      Function usePages has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
      Open

      export const usePages = (): PageType & EnterprisePageType => {
        const enterprisePages: EnterprisePageType = isEnterprise()
          ? {
              permissions: {
                name: "components.mainMenu.permissions",
      Severity: Minor
      Found in ui/src/util/router/pages.tsx - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function useParams has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            useParams: () => {
              const { "*": path, namespace } = useParams();
              const [, , thirdLvl, fourthLvl] = useMatches(); // first level is namespace level
              const [searchParams] = useSearchParams();
      
      
      Severity: Minor
      Found in ui/src/util/router/pages.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            instances: {
              name: "components.mainMenu.instances",
              icon: Boxes,
              createHref: (params) =>
                `/n/${params.namespace}/instances${
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 1 day to fix
        ui/src/util/router/pages.tsx on lines 621..666

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 285.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            services: {
              name: "components.mainMenu.services",
              icon: Layers,
              createHref: (params) =>
                `/n/${params.namespace}/services${
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 1 day to fix
        ui/src/util/router/pages.tsx on lines 477..522

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 285.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  route: {
                    path: "permissions",
                    element: <PermissionsPage />,
                    handle: { permissions: true, isPermissionsPage: true },
                    children: [
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 4 hrs to fix
        ui/src/util/router/pages.tsx on lines 598..619

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 131.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              route: {
                path: "gateway",
                element: <GatewayPage />,
                handle: { gateway: true, isGatewayPage: true },
                children: [
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 4 hrs to fix
        ui/src/util/router/pages.tsx on lines 294..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 131.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            monitoring: {
              name: "components.mainMenu.monitoring",
              icon: ActivitySquare,
              createHref: (params) => `/n/${params.namespace}/monitoring`,
              useParams: () => {
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 2 other locations - About 4 hrs to fix
        ui/src/util/router/pages.tsx on lines 704..718
        ui/src/util/router/pages.tsx on lines 719..736

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            settings: {
              name: "components.mainMenu.settings",
              icon: Settings,
              createHref: (params) => `/n/${params.namespace}/settings`,
              useParams: () => {
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 2 other locations - About 4 hrs to fix
        ui/src/util/router/pages.tsx on lines 462..476
        ui/src/util/router/pages.tsx on lines 719..736

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            jqPlayground: {
              name: "components.mainMenu.jqPlayground",
              icon: PlaySquare,
              createHref: (params) => `/n/${params.namespace}/jq`,
              useParams: () => {
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 2 other locations - About 4 hrs to fix
        ui/src/util/router/pages.tsx on lines 462..476
        ui/src/util/router/pages.tsx on lines 704..718

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        type InstancesPageSetup = Record<
          "instances",
          PageBase & {
            createHref: (params: { namespace: string; instance?: string }) => string;
            useParams: () => {
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 3 hrs to fix
        ui/src/util/router/pages.tsx on lines 128..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        type ServicesPageSetup = Record<
          "services",
          PageBase & {
            createHref: (params: { namespace: string; service?: string }) => string;
            useParams: () => {
        Severity: Major
        Found in ui/src/util/router/pages.tsx and 1 other location - About 3 hrs to fix
        ui/src/util/router/pages.tsx on lines 114..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status