Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/provisioners/nutanix/nutanix.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Provisioner.Provision has 90 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {

    authHeader := fmt.Sprintf("Basic %s", base64.StdEncoding.EncodeToString([]byte(fmt.Sprintf("%s:%s", p.cfg.Username, p.cfg.Password))))
    if args.Description != "" {
        p.log.Warnf(`The 'description' field is ignored by Nutanix provision operation`)
Severity: Major
Found in pkg/provisioners/nutanix/nutanix.go - About 2 hrs to fix

    Method Provisioner.Provision has 14 return statements (exceeds 4 allowed).
    Open

    func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {

    authHeader := fmt.Sprintf("Basic %s", base64.StdEncoding.EncodeToString([]byte(fmt.Sprintf("%s:%s", p.cfg.Username, p.cfg.Password))))
    if args.Description != "" {
        p.log.Warnf(`The 'description' field is ignored by Nutanix provision operation`)
    Severity: Major
    Found in pkg/provisioners/nutanix/nutanix.go - About 1 hr to fix

      Method Provisioner.Validate has 5 return statements (exceeds 4 allowed).
      Open

      func (p *Provisioner) Validate() error {
    if p.cfg.Username == "" || p.cfg.Password == "" || p.cfg.Host == "" {
        return fmt.Errorf("username,password and host fields should not be empty")
    }
      Severity: Major
      Found in pkg/provisioners/nutanix/nutanix.go - About 35 mins to fix

        Method Provisioner.Provision has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {

    authHeader := fmt.Sprintf("Basic %s", base64.StdEncoding.EncodeToString([]byte(fmt.Sprintf("%s:%s", p.cfg.Username, p.cfg.Password))))
    if args.Description != "" {
        p.log.Warnf(`The 'description' field is ignored by Nutanix provision operation`)
        Severity: Minor
        Found in pkg/provisioners/nutanix/nutanix.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
    err := p.Validate()
        Severity: Major
        Found in pkg/provisioners/nutanix/nutanix.go and 4 other locations - About 45 mins to fix
        pkg/provisioners/amazon/amazon.go on lines 71..82
        pkg/provisioners/azure/azure.go on lines 62..72
        pkg/provisioners/google/google.go on lines 146..157
        pkg/provisioners/vcenter/vcenter.go on lines 58..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package nutanix
        Severity: Minor
        Found in pkg/provisioners/nutanix/nutanix.go by gofmt

        There are no issues that match your filters.

        Category
        Status