Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/provisioners/vcenter/vcenter.go

Summary

Maintainability
C
1 day
Test Coverage

Method Provisioner.Provision has 111 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
    var err error

    // report that the 'description' flag is ignored if using this provisioner
    if args.Description != "" {
Severity: Major
Found in pkg/provisioners/vcenter/vcenter.go - About 3 hrs to fix

    Method Provisioner.Provision has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
    Open

    func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
    var err error

    // report that the 'description' flag is ignored if using this provisioner
    if args.Description != "" {
    Severity: Minor
    Found in pkg/provisioners/vcenter/vcenter.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Provisioner.Provision has 16 return statements (exceeds 4 allowed).
    Open

    func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
    var err error

    // report that the 'description' flag is ignored if using this provisioner
    if args.Description != "" {
    Severity: Major
    Found in pkg/provisioners/vcenter/vcenter.go - About 1 hr to fix

      Method Provisioner.Validate has 6 return statements (exceeds 4 allowed).
      Open

      func (p *Provisioner) Validate() error {
    loginURL, err := url.Parse(p.cfg.Address + "/sdk")
    if err != nil {
        return err
    }
      Severity: Major
      Found in pkg/provisioners/vcenter/vcenter.go - About 40 mins to fix

        Method Provisioner.init has 6 return statements (exceeds 4 allowed).
        Open

        func (p *Provisioner) init() error {
    ctx := context.Background()

    // TODO test connection
    loginURL, err := url.Parse(p.cfg.Address + "/sdk")
        Severity: Major
        Found in pkg/provisioners/vcenter/vcenter.go - About 40 mins to fix

          TODO found
          Open

              // TODO test connection
          Severity: Minor
          Found in pkg/provisioners/vcenter/vcenter.go by fixme

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
    err := p.Validate()
          Severity: Major
          Found in pkg/provisioners/vcenter/vcenter.go and 4 other locations - About 45 mins to fix
          pkg/provisioners/amazon/amazon.go on lines 71..82
          pkg/provisioners/azure/azure.go on lines 62..72
          pkg/provisioners/google/google.go on lines 146..157
          pkg/provisioners/nutanix/nutanix.go on lines 37..47

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package vcenter
          Severity: Minor
          Found in pkg/provisioners/vcenter/vcenter.go by gofmt

          There are no issues that match your filters.

          Category
          Status