Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vdecompiler/fs.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method IO.exploreExtentsTree has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (iio *IO) exploreExtentsTree(hdr *ext4ExtentHeader, blockSize int64, data []byte, blockAddrs *[]int, c *int) error {
Severity: Minor
Found in pkg/vdecompiler/fs.go - About 35 mins to fix

    Method IO.readSuperblock has 5 return statements (exceeds 4 allowed).
    Open

    func (iio *IO) readSuperblock(index int) (*ext.Superblock, error) {

    entry, err := iio.GPTEntry(UTF16toString(vimg.RootPartitionName))
    if err != nil {
        return nil, err
    Severity: Major
    Found in pkg/vdecompiler/fs.go - About 35 mins to fix

      Method IO.readBGDT has 5 return statements (exceeds 4 allowed).
      Open

      func (iio *IO) readBGDT(index int) ([]*ext.BlockGroupDescriptorTableEntry, error) {

    sb, err := iio.Superblock(0)
    if err != nil {
        return nil, err
      Severity: Major
      Found in pkg/vdecompiler/fs.go - About 35 mins to fix

        TODO found
        Open

            // TODO: check for out of bounds
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by fixme

        TODO found
        Open

            // TODO: check that index isn't out of bounds
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by fixme

        TODO found
        Open

                    (*blockAddrs)[*c] = baddr + j // TODO: catch corruption
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by fixme

        TODO found
        Open

            // TODO: check that index isn't out of bounds
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by fixme

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (iio *IO) BGDT(index int) ([]*ext.BlockGroupDescriptorTableEntry, error) {

    // only return a cached bgdt if index is zero
    if index == 0 && iio.fs.bgdt != nil {
        return iio.fs.bgdt, nil
        Severity: Major
        Found in pkg/vdecompiler/fs.go and 1 other location - About 1 hr to fix
        pkg/vdecompiler/fs.go on lines 59..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 137.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (iio *IO) Superblock(index int) (*ext.Superblock, error) {

    // only return a cached superblock if index is zero
    if index == 0 && iio.fs.superblock != nil {
        return iio.fs.superblock, nil
        Severity: Major
        Found in pkg/vdecompiler/fs.go and 1 other location - About 1 hr to fix
        pkg/vdecompiler/fs.go on lines 123..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 137.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package vdecompiler
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by gofmt

        exported type Dirent should have comment or be unexported
        Open

        type Dirent struct {
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by golint

        exported type DirectoryEntry should have comment or be unexported
        Open

        type DirectoryEntry struct {
        Severity: Minor
        Found in pkg/vdecompiler/fs.go by golint

        There are no issues that match your filters.

        Category
        Status