Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vhd/dynamic.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method DynamicWriter.writeRedundantFooter has 71 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *DynamicWriter) writeRedundantFooter() error {
    conectix := uint64(0x636F6E6563746978)
    timestamp := time.Now().Unix() - 946684800 // 2000 offset

    // CHS crap
Severity: Minor
Found in pkg/vhd/dynamic.go - About 1 hr to fix

    Method DynamicWriter.Seek has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (w *DynamicWriter) Seek(offset int64, whence int) (int64, error) {

    var abs int64
    switch whence {
    case io.SeekStart:
    Severity: Minor
    Found in pkg/vhd/dynamic.go - About 1 hr to fix

      Method DynamicWriter.Seek has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func (w *DynamicWriter) Seek(offset int64, whence int) (int64, error) {

    var abs int64
    switch whence {
    case io.SeekStart:
      Severity: Minor
      Found in pkg/vhd/dynamic.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method DynamicWriter.Seek has 6 return statements (exceeds 4 allowed).
      Open

      func (w *DynamicWriter) Seek(offset int64, whence int) (int64, error) {

    var abs int64
    switch whence {
    case io.SeekStart:
      Severity: Major
      Found in pkg/vhd/dynamic.go - About 40 mins to fix

        Method DynamicWriter.writeHeader has 5 return statements (exceeds 4 allowed).
        Open

        func (w *DynamicWriter) writeHeader() error {
    // sparse drive header
    cxsparse := uint64(0x6378737061727365)
    header := &header{
        Cookie:          cxsparse,
        Severity: Major
        Found in pkg/vhd/dynamic.go - About 35 mins to fix

          Method DynamicWriter.writeRedundantFooter has 5 return statements (exceeds 4 allowed).
          Open

          func (w *DynamicWriter) writeRedundantFooter() error {
    conectix := uint64(0x636F6E6563746978)
    timestamp := time.Now().Unix() - 946684800 // 2000 offset

    // CHS crap
          Severity: Major
          Found in pkg/vhd/dynamic.go - About 35 mins to fix

            TODO found
            Open

                    CreatorVersion:     0x00010000, // TODO: does this matter?
            Severity: Minor
            Found in pkg/vhd/dynamic.go by fixme

            TODO found
            Open

                    CreatorHostOS:      0x5769326B, // TODO: does this matter?
            Severity: Minor
            Found in pkg/vhd/dynamic.go by fixme

            TODO found
            Open

                    // TODO: UniqueID
            Severity: Minor
            Found in pkg/vhd/dynamic.go by fixme

            TODO found
            Open

                    checksum += uint32(x) // TODO: does this achieve one's complement?
            Severity: Minor
            Found in pkg/vhd/dynamic.go by fixme

            TODO found
            Open

                    checksum += uint32(x) // TODO: does this achieve one's complement?
            Severity: Minor
            Found in pkg/vhd/dynamic.go by fixme

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                if totalSectors >= 65525*16*63 {
        sectorsPerTrack = 255
        heads = 16
        cylinderTimesHeads = totalSectors / sectorsPerTrack
    } else {
            Severity: Major
            Found in pkg/vhd/dynamic.go and 2 other locations - About 1 hr to fix
            pkg/vhd/fixed.go on lines 72..93
            pkg/vhd/fixed.go on lines 181..202

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 160.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                footer := &footer{
        Cookie:             conectix,
        Features:           0x00000002,
        FileFormatVersion:  0x00010000,
        DataOffset:         512,
            Severity: Minor
            Found in pkg/vhd/dynamic.go and 1 other location - About 50 mins to fix
            pkg/vhd/fixed.go on lines 206..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 122.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            exported type DynamicWriter should have comment or be unexported
            Open

            type DynamicWriter struct {
            Severity: Minor
            Found in pkg/vhd/dynamic.go by golint

            exported method DynamicWriter.Seek should have comment or be unexported
            Open

            func (w *DynamicWriter) Seek(offset int64, whence int) (int64, error) {
            Severity: Minor
            Found in pkg/vhd/dynamic.go by golint

            exported method DynamicWriter.Close should have comment or be unexported
            Open

            func (w *DynamicWriter) Close() error {
            Severity: Minor
            Found in pkg/vhd/dynamic.go by golint

            exported function NewDynamicWriter should have comment or be unexported
            Open

            func NewDynamicWriter(w io.WriteSeeker, h HolePredictor) (*DynamicWriter, error) {
            Severity: Minor
            Found in pkg/vhd/dynamic.go by golint

            There are no issues that match your filters.

            Category
            Status