Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vimg/os.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Builder.validateConfig has 8 return statements (exceeds 4 allowed).
Open

func (b *Builder) validateConfig() error {

    for i, p := range b.vcfg.Programs {

        if p.Binary == "" && p.Args == "" {
Severity: Major
Found in pkg/vimg/os.go - About 50 mins to fix

    Method Builder.validateConfig has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (b *Builder) validateConfig() error {

    for i, p := range b.vcfg.Programs {

        if p.Binary == "" && p.Args == "" {
    Severity: Minor
    Found in pkg/vimg/os.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Builder.validateOSArgs has 5 return statements (exceeds 4 allowed).
    Open

    func (b *Builder) validateOSArgs(ctx context.Context) error {

    b.linuxArgs = b.vcfg.System.KernelArgs

    b.determineKernelTags()
    Severity: Major
    Found in pkg/vimg/os.go - About 35 mins to fix

      TODO found
      Open

              // TODO: validate bootstrap?
      Severity: Minor
      Found in pkg/vimg/os.go by fixme

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (b *Builder) writeKernelAndConfig(ctx context.Context, w io.WriteSeeker) error {

    err := b.writeKernel(ctx, w)
    if err != nil {
        return err
      Severity: Minor
      Found in pkg/vimg/os.go and 2 other locations - About 30 mins to fix
      pkg/vimg/partitions.go on lines 76..90
      pkg/vimg/partitions.go on lines 92..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      if block ends with a return statement, so drop this else and outdent its block
      Open

              } else {
      Severity: Minor
      Found in pkg/vimg/os.go by golint

      There are no issues that match your filters.

      Category
      Status