Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/virtualizers/firecracker/util_linux.go

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function SetupBridge has 6 return statements (exceeds 4 allowed).
Open

func SetupBridge(log elog.View, ip string) error {

    bridgeExists := true
    // Create bridge device
    bridger, err := tenus.NewBridgeWithName(vorteilBridge)
Severity: Major
Found in pkg/virtualizers/firecracker/util_linux.go - About 40 mins to fix

    Function createIfc has 6 return statements (exceeds 4 allowed).
    Open

    func createIfc(name string) error {

    var (
        tunfd int
        err   error
    Severity: Major
    Found in pkg/virtualizers/firecracker/util_linux.go - About 40 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
      Severity: Major
      Found in pkg/virtualizers/firecracker/util_linux.go and 4 other locations - About 1 hr to fix
      pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
      pkg/virtualizers/qemu/virtualizer.go on lines 128..145
      pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
      pkg/virtualizers/vmware/virtualizer.go on lines 388..405

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      // +build linux
      Severity: Minor
      Found in pkg/virtualizers/firecracker/util_linux.go by gofmt

      comment on exported function SetupBridge should be of the form "SetupBridge ..."
      Open

      // SetupBridgeAndDHCPServer creates the bridge which provides DHCP addresses todo
      Severity: Minor
      Found in pkg/virtualizers/firecracker/util_linux.go by golint

      There are no issues that match your filters.

      Category
      Status