Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/virtualizers/qemu/virtualizer.go

Summary

Maintainability
B
5 hrs
Test Coverage
F
22%

Method Virtualizer.Bind has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (v *Virtualizer) Bind(args string, i int, j int, protocol string, port virtualizers.RouteMap, networkType string) (string, string, bool, error) {
Severity: Minor
Found in pkg/virtualizers/qemu/virtualizer.go - About 45 mins to fix

    Method Virtualizer.initializeNetworkCards has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (v *Virtualizer) initializeNetworkCards() ([]string, error) {
    v.logger.Debugf("Initializing Network Cards")
    var nicArgs string
    var err error
    var nr string
    Severity: Minor
    Found in pkg/virtualizers/qemu/virtualizer.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createArgs has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func createArgs(cpus uint, memory int, headless bool, diskpath string, diskformat string) string {
    Severity: Minor
    Found in pkg/virtualizers/qemu/virtualizer.go - About 35 mins to fix

      Method Virtualizer.initializeNetworkCards has 5 return statements (exceeds 4 allowed).
      Open

      func (v *Virtualizer) initializeNetworkCards() ([]string, error) {
    v.logger.Debugf("Initializing Network Cards")
    var nicArgs string
    var err error
    var nr string
      Severity: Major
      Found in pkg/virtualizers/qemu/virtualizer.go - About 35 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
        Severity: Major
        Found in pkg/virtualizers/qemu/virtualizer.go and 4 other locations - About 1 hr to fix
        pkg/virtualizers/firecracker/util_linux.go on lines 256..273
        pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
        pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
        pkg/virtualizers/vmware/virtualizer.go on lines 388..405

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 164.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (v *Virtualizer) Download() (vio.File, error) {
    v.logger.Debugf("Downloading Disk")

    if !(v.state == virtualizers.Ready) {
        return nil, fmt.Errorf("the machine must be in a stopped or ready state")
        Severity: Major
        Found in pkg/virtualizers/qemu/virtualizer.go and 2 other locations - About 1 hr to fix
        pkg/virtualizers/firecracker/virtualizer_linux.go on lines 137..149
        pkg/virtualizers/vmware/virtualizer.go on lines 446..459

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 128.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

        func (v *Virtualizer) Details() (string, string, string, []virtualizers.NetworkInterface, time.Time, *vcfg.VCFG, interface{}) {
    return v.name, v.pname, v.state, v.routes, v.created, v.config, v.source
}
        Severity: Major
        Found in pkg/virtualizers/qemu/virtualizer.go and 4 other locations - About 35 mins to fix
        pkg/virtualizers/firecracker/virtualizer_linux.go on lines 44..46
        pkg/virtualizers/hyperv/virtualizer.go on lines 196..198
        pkg/virtualizers/virtualbox/virtualizer.go on lines 206..208
        pkg/virtualizers/vmware/virtualizer.go on lines 462..464

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        error strings should not be capitalized or end with punctuation or a newline
        Open

                return errors.New("vm is already stopped.")
        Severity: Minor
        Found in pkg/virtualizers/qemu/virtualizer.go by golint

        error strings should not be capitalized or end with punctuation or a newline
        Open

                    if err != nil && err.Error() != fmt.Errorf("The pipe is being closed.").Error() && err.Error() != fmt.Errorf("write unix @->%s: write: broken pipe", filepath.ToSlash(filepath.Join(v.folder, "monitor.sock"))).Error() {
        Severity: Minor
        Found in pkg/virtualizers/qemu/virtualizer.go by golint

        error strings should not be capitalized or end with punctuation or a newline
        Open

                    if err != nil && err.Error() != fmt.Errorf("The pipe is being closed.").Error() && err.Error() != fmt.Errorf("write unix ->%s: write: broken pipe", filepath.ToSlash(filepath.Join(v.folder, "monitor.sock"))).Error() && err.Error() != fmt.Errorf("write unix @->%s: write: broken pipe", filepath.ToSlash(filepath.Join(v.folder, "monitor.sock"))).Error() {
        Severity: Minor
        Found in pkg/virtualizers/qemu/virtualizer.go by golint

        exported method Virtualizer.Bind should have comment or be unexported
        Open

        func (v *Virtualizer) Bind(args string, i int, j int, protocol string, port virtualizers.RouteMap, networkType string) (string, string, bool, error) {
        Severity: Minor
        Found in pkg/virtualizers/qemu/virtualizer.go by golint

        There are no issues that match your filters.

        Category
        Status