Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/virtualizers/virtualbox/virtualizer.go

Summary

Maintainability
D
1 day
Test Coverage
F
4%

File virtualizer.go has 581 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package virtualbox

/**
 * SPDX-License-Identifier: Apache-2.0
 * Copyright 2020 vorteil.io Pty Ltd
Severity: Minor
Found in pkg/virtualizers/virtualbox/virtualizer.go - About 3 hrs to fix

    Method Virtualizer.Close has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func (v *Virtualizer) Close(force bool) error {
    v.logger.Debugf("Deleting VM")
    if force && !(v.state == virtualizers.Ready) {
        err := v.ForceStop()
        if err != nil {
    Severity: Minor
    Found in pkg/virtualizers/virtualbox/virtualizer.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Virtualizer.Close has 7 return statements (exceeds 4 allowed).
    Open

    func (v *Virtualizer) Close(force bool) error {
    v.logger.Debugf("Deleting VM")
    if force && !(v.state == virtualizers.Ready) {
        err := v.ForceStop()
        if err != nil {
    Severity: Major
    Found in pkg/virtualizers/virtualbox/virtualizer.go - About 45 mins to fix

      Method Virtualizer.Bind has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (v *Virtualizer) Bind(args []string, i int, j int, protocol string, port virtualizers.RouteMap, networkType string) ([]string, string, bool, error) {
      Severity: Minor
      Found in pkg/virtualizers/virtualbox/virtualizer.go - About 45 mins to fix

        Method Virtualizer.createAndConfigure has 5 return statements (exceeds 4 allowed).
        Open

        func (v *Virtualizer) createAndConfigure(diskpath string) error {
    cVMArgs := createVM(v.folder, v.name)
    cmd := exec.Command("VBoxManage", cVMArgs...)
    err := v.execute(cmd)
    if err != nil {
        Severity: Major
        Found in pkg/virtualizers/virtualbox/virtualizer.go - About 35 mins to fix

          Method Virtualizer.handlePorts has 5 return statements (exceeds 4 allowed).
          Open

          func (v *Virtualizer) handlePorts(args []string, route virtualizers.NetworkInterface, protocol string, i int) ([]string, bool, error) {
    var err error
    var nr string
    var hasDefinedPorts bool
    for j, port := range route.HTTP {
          Severity: Major
          Found in pkg/virtualizers/virtualbox/virtualizer.go - About 35 mins to fix

            Method Virtualizer.Start has 5 return statements (exceeds 4 allowed).
            Open

            func (v *Virtualizer) Start() error {
    v.logger.Debugf("Starting VM")
    switch v.State() {
    case "ready":
        v.state = virtualizers.Changing
            Severity: Major
            Found in pkg/virtualizers/virtualbox/virtualizer.go - About 35 mins to fix

              Method Virtualizer.Stop has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
              Open

              func (v *Virtualizer) Stop() error {
    v.logger.Debugf("Stopping VM")
    if v.state != virtualizers.Ready {
        v.state = virtualizers.Changing
        err := v.execute(exec.Command("VBoxManage", "controlvm", v.name, "acpipowerbutton"))
              Severity: Minor
              Found in pkg/virtualizers/virtualbox/virtualizer.go - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

              func (o *operation) finished(err error) {
    o.finishedLock.Lock()
    defer o.finishedLock.Unlock()
    if o.isFinished {
        return
              Severity: Major
              Found in pkg/virtualizers/virtualbox/virtualizer.go and 4 other locations - About 1 hr to fix
              pkg/virtualizers/firecracker/util_linux.go on lines 256..273
              pkg/virtualizers/hyperv/virtualizer.go on lines 263..281
              pkg/virtualizers/qemu/virtualizer.go on lines 128..145
              pkg/virtualizers/vmware/virtualizer.go on lines 388..405

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 164.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (o *operation) checkIfBridged() (bool, error) {
    var deviceIsBridged bool
    if o.networkType == "bridged" {
        devices, err := virtualizers.BridgedDevices()
        if err != nil {
              Severity: Major
              Found in pkg/virtualizers/virtualbox/virtualizer.go and 1 other location - About 1 hr to fix
              pkg/virtualizers/virtualbox/virtualizer.go on lines 665..684

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 141.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (o *operation) checkIfHost() (bool, error) {
    var deviceIsHost bool
    if o.networkType == "hostonly" {
        devices, err := virtualizers.HostDevices()
        if err != nil {
              Severity: Major
              Found in pkg/virtualizers/virtualbox/virtualizer.go and 1 other location - About 1 hr to fix
              pkg/virtualizers/virtualbox/virtualizer.go on lines 644..662

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 141.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 5 locations. Consider refactoring.
              Open

              func (v *Virtualizer) Details() (string, string, string, []virtualizers.NetworkInterface, time.Time, *vcfg.VCFG, interface{}) {
    return v.name, v.pname, v.state, v.routes, v.created, v.config, v.source
}
              Severity: Major
              Found in pkg/virtualizers/virtualbox/virtualizer.go and 4 other locations - About 35 mins to fix
              pkg/virtualizers/firecracker/virtualizer_linux.go on lines 44..46
              pkg/virtualizers/hyperv/virtualizer.go on lines 196..198
              pkg/virtualizers/qemu/virtualizer.go on lines 375..377
              pkg/virtualizers/vmware/virtualizer.go on lines 462..464

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 103.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              exported method Virtualizer.Bind should have comment or be unexported
              Open

              func (v *Virtualizer) Bind(args []string, i int, j int, protocol string, port virtualizers.RouteMap, networkType string) ([]string, string, bool, error) {
              Severity: Minor
              Found in pkg/virtualizers/virtualbox/virtualizer.go by golint

              There are no issues that match your filters.

              Category
              Status