Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vkern/manager-remote.go

Summary

Maintainability
C
1 day
Test Coverage

Method RemoteManager.get has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (mgr *RemoteManager) get(version CalVer) error {

    Logger("Downloading kernel version: %s", version.String())

    kernelName := filenameFromVersion(version)
Severity: Minor
Found in pkg/vkern/manager-remote.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method RemoteManager.get has 78 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (mgr *RemoteManager) get(version CalVer) error {

    Logger("Downloading kernel version: %s", version.String())

    kernelName := filenameFromVersion(version)
Severity: Major
Found in pkg/vkern/manager-remote.go - About 2 hrs to fix

    Method RemoteManager.remoteList has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (mgr *RemoteManager) remoteList(ctx context.Context) (List, error) {

    var list List

    // request remote manifest
    Severity: Minor
    Found in pkg/vkern/manager-remote.go - About 1 hr to fix

      Method RemoteManager.remoteList has 8 return statements (exceeds 4 allowed).
      Open

      func (mgr *RemoteManager) remoteList(ctx context.Context) (List, error) {

    var list List

    // request remote manifest
      Severity: Major
      Found in pkg/vkern/manager-remote.go - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if firstError == nil {
                            firstError = err
                        }
        Severity: Major
        Found in pkg/vkern/manager-remote.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              } else if resp.HTTPResponse.StatusCode != http.StatusOK {
                        err = fmt.Errorf("error downloading %s: %v -- %s", resp.Request.URL(), resp.HTTPResponse.StatusCode, http.StatusText(resp.HTTPResponse.StatusCode))
                        if firstError == nil {
                            firstError = err
                        }
          Severity: Major
          Found in pkg/vkern/manager-remote.go - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status