Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vmdk/sparse.go

Summary

Maintainability
C
1 day
Test Coverage

Method SparseWriter.writeGrainData has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *SparseWriter) writeGrainData() error {
    var err error

    firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
Severity: Major
Found in pkg/vmdk/sparse.go - About 2 hrs to fix

    Method SparseWriter.writeGrainData has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func (w *SparseWriter) writeGrainData() error {
    var err error

    firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
    Severity: Minor
    Found in pkg/vmdk/sparse.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method SparseWriter.writeGrainData has 10 return statements (exceeds 4 allowed).
    Open

    func (w *SparseWriter) writeGrainData() error {
    var err error

    firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
    Severity: Major
    Found in pkg/vmdk/sparse.go - About 1 hr to fix

      TODO found
      Open

          // TODO: check not writing into a forbidden grain
      Severity: Minor
      Found in pkg/vmdk/sparse.go by fixme

      TODO found
      Open

          // TODO: this seems like a bug...
      Severity: Minor
      Found in pkg/vmdk/sparse.go by fixme

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalDataGrains; i++ {

        grainSector := int64(w.grainOffsets[i])
        if i+1 < int64(len(w.grainOffsets)) && grainSector == int64(w.grainOffsets[i+1]) {
            grainSector = 0
      Severity: Major
      Found in pkg/vmdk/sparse.go and 1 other location - About 1 hr to fix
      pkg/vmdk/sparse.go on lines 180..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 185.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalDataGrains; i++ {

        grainSector := int64(w.grainOffsets[i])
        if i+1 < int64(len(w.grainOffsets)) && grainSector == int64(w.grainOffsets[i+1]) {
            grainSector = 0
      Severity: Major
      Found in pkg/vmdk/sparse.go and 1 other location - About 1 hr to fix
      pkg/vmdk/sparse.go on lines 134..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 185.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalTables; i++ {
        tableSector := int64(0)
        if i < w.totalTables {
            tableSector = firstTableSector + i*4
        }
      Severity: Minor
      Found in pkg/vmdk/sparse.go and 1 other location - About 35 mins to fix
      pkg/vmdk/sparse.go on lines 116..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for i := int64(0); i < w.totalTables; i++ {
        tableSector := int64(0)
        if i < w.totalTables {
            tableSector = firstTableSector + i*4
        }
      Severity: Minor
      Found in pkg/vmdk/sparse.go and 1 other location - About 35 mins to fix
      pkg/vmdk/sparse.go on lines 162..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported type SparseWriter should have comment or be unexported
      Open

      type SparseWriter struct {
      Severity: Minor
      Found in pkg/vmdk/sparse.go by golint

      exported function NewSparseWriter should have comment or be unexported
      Open

      func NewSparseWriter(w io.WriteSeeker, h HolePredictor) (*SparseWriter, error) {
      Severity: Minor
      Found in pkg/vmdk/sparse.go by golint

      exported method SparseWriter.Seek should have comment or be unexported
      Open

      func (w *SparseWriter) Seek(offset int64, whence int) (int64, error) {
      Severity: Minor
      Found in pkg/vmdk/sparse.go by golint

      exported type HolePredictor should have comment or be unexported
      Open

      type HolePredictor interface {
      Severity: Minor
      Found in pkg/vmdk/sparse.go by golint

      exported method SparseWriter.Close should have comment or be unexported
      Open

      func (w *SparseWriter) Close() error {
      Severity: Minor
      Found in pkg/vmdk/sparse.go by golint

      There are no issues that match your filters.

      Category
      Status