Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/xfs/dir.go

Summary

Maintainability
D
1 day
Test Coverage

File dir.go has 659 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package xfs

import (
    "bytes"
    "encoding/binary"
Severity: Minor
Found in pkg/xfs/dir.go - About 5 hrs to fix

    TODO found
    Open

            if space-l < 16 { // TODO: Really? Why 16? Why not zero?
    Severity: Minor
    Found in pkg/xfs/dir.go by fixme

    TODO found
    Open

            if space-l < 16 { // TODO: Really? Why 16? Why not zero?
    Severity: Minor
    Found in pkg/xfs/dir.go by fixme

    TODO found
    Open

            // TODO: shuffle entries to optimize used space
    Severity: Minor
    Found in pkg/xfs/dir.go by fixme

    TODO found
    Open

        err = binary.Write(buf, binary.BigEndian, uint32(ino)) // TODO: what if the translated number > 32 bit?
    Severity: Minor
    Found in pkg/xfs/dir.go by fixme

    TODO found
    Open

            // TODO: shuffle entries to optimize used space
    Severity: Minor
    Found in pkg/xfs/dir.go by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (b *nodeDirBuilder) writeDataBlock(w io.Writer, n int64, dentries []*dentry) {

    space := b.c.blockSize() - 16
    offset := 16 + n*b.c.blockSize()
    Severity: Major
    Found in pkg/xfs/dir.go and 1 other location - About 1 hr to fix
    pkg/xfs/dir.go on lines 441..450

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (b *leafDirBuilder) writeDataBlock(w io.Writer, n int64, dentries []*dentry) {

    space := b.c.blockSize() - 16
    offset := 16 + n*b.c.blockSize()
    Severity: Major
    Found in pkg/xfs/dir.go and 1 other location - About 1 hr to fix
    pkg/xfs/dir.go on lines 618..627

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        addEntry := func(inode uint64, name string, ftype uint8) {

        l := align(int64(11+len(name)), 8)
        if space-l < 16 { // TODO: Really? Why 16? Why not zero?
            space = b.c.blockSize() - 16
    Severity: Major
    Found in pkg/xfs/dir.go and 1 other location - About 1 hr to fix
    pkg/xfs/dir.go on lines 586..601

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        addEntry := func(inode uint64, name string, ftype uint8) {

        l := align(int64(11+len(name)), 8)
        if space-l < 16 { // TODO: Really? Why 16? Why not zero?
            space = b.c.blockSize() - 16
    Severity: Major
    Found in pkg/xfs/dir.go and 1 other location - About 1 hr to fix
    pkg/xfs/dir.go on lines 409..424

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (c *compiler) generateLeafFormDirectoryData(n *vio.TreeNode, blocks int64, extents []*extent) io.Reader {

    b := &leafDirBuilder{
        n:       n,
        c:       c,
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 40 mins to fix
    pkg/xfs/dir.go on lines 779..792

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (c *compiler) generateNodeFormDirectoryData(n *vio.TreeNode, blocks int64, extents []*extent) io.Reader {

    b := &nodeDirBuilder{
        n:       n,
        c:       c,
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 40 mins to fix
    pkg/xfs/dir.go on lines 533..546

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        grow := func(child string) {
        l := int64(len(child))
        l = 11 + l
        l = align(l, 8) // round up to nearest 8
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 35 mins to fix
    pkg/xfs/dir.go on lines 825..838

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        grow := func(child string) {
        l := int64(len(child))
        l = 11 + l
        l = align(l, 8) // round up to nearest 8
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 35 mins to fix
    pkg/xfs/dir.go on lines 880..893

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        for _, child := range b.n.Children {
        ftype := uint8(FTypeRegularFile)
        if child.File.IsDir() {
            ftype = FTypeDirectory
        } else if child.File.IsSymlink() {
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 30 mins to fix
    pkg/xfs/dir.go on lines 429..437

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        for _, child := range b.n.Children {
        ftype := uint8(FTypeRegularFile)
        if child.File.IsDir() {
            ftype = FTypeDirectory
        } else if child.File.IsSymlink() {
    Severity: Minor
    Found in pkg/xfs/dir.go and 1 other location - About 30 mins to fix
    pkg/xfs/dir.go on lines 606..614

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    should replace leafBlocks += 1 with leafBlocks++
    Open

        leafBlocks += 1
    Severity: Minor
    Found in pkg/xfs/dir.go by golint

    should replace blockNo += 1 with blockNo++
    Open

            blockNo += 1
    Severity: Minor
    Found in pkg/xfs/dir.go by golint

    should replace b.leafBlocks -= 1 with b.leafBlocks--
    Open

        b.leafBlocks -= 1
    Severity: Minor
    Found in pkg/xfs/dir.go by golint

    should replace leafBlocks += 1 with leafBlocks++
    Open

        leafBlocks += 1
    Severity: Minor
    Found in pkg/xfs/dir.go by golint

    There are no issues that match your filters.

    Category
    Status