voucherifyio/voucherify-ruby-sdk

View on GitHub
lib/VoucherifySdk/api/validation_rules_api.rb

Summary

Maintainability
F
6 days
Test Coverage

File validation_rules_api.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'cgi'

module VoucherifySdk
  class ValidationRulesApi
    attr_accessor :api_client
Severity: Minor
Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 3 hrs to fix

    Method list_validation_rule_assignments_with_http_info has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private def list_validation_rule_assignments_with_http_info(validation_rule_id, opts = {})
          if @api_client.config.debugging
            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rule_assignments ...'
          end
          # verify the required parameter 'validation_rule_id' is set
    Severity: Minor
    Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

      Method list_validation_rules_with_http_info has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private def list_validation_rules_with_http_info(opts = {})
            if @api_client.config.debugging
              @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules ...'
            end
            if @api_client.config.client_side_validation && !opts[:'limit'].nil? && opts[:'limit'] > 100
      Severity: Minor
      Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

        Method list_validation_rules_assignments_with_http_info has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private def list_validation_rules_assignments_with_http_info(opts = {})
              if @api_client.config.debugging
                @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules_assignments ...'
              end
              if @api_client.config.client_side_validation && !opts[:'page'].nil? && opts[:'page'] > 100
        Severity: Minor
        Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

          Method list_validation_rules_with_http_info has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private def list_validation_rules_with_http_info(opts = {})
                if @api_client.config.debugging
                  @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules ...'
                end
                if @api_client.config.client_side_validation && !opts[:'limit'].nil? && opts[:'limit'] > 100
          Severity: Minor
          Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method list_validation_rules_assignments_with_http_info has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private def list_validation_rules_assignments_with_http_info(opts = {})
                if @api_client.config.debugging
                  @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules_assignments ...'
                end
                if @api_client.config.client_side_validation && !opts[:'page'].nil? && opts[:'page'] > 100
          Severity: Minor
          Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_validation_rule_with_http_info has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private def update_validation_rule_with_http_info(validation_rule_id, opts = {})
                if @api_client.config.debugging
                  @api_client.config.logger.debug 'Calling API: ValidationRulesApi.update_validation_rule ...'
                end
                # verify the required parameter 'validation_rule_id' is set
          Severity: Minor
          Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

            Method list_validation_rule_assignments_with_http_info has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                private def list_validation_rule_assignments_with_http_info(validation_rule_id, opts = {})
                  if @api_client.config.debugging
                    @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rule_assignments ...'
                  end
                  # verify the required parameter 'validation_rule_id' is set
            Severity: Minor
            Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method delete_validation_rule_assignment_with_http_info has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private def delete_validation_rule_assignment_with_http_info(validation_rule_id, assignment_id, opts = {})
                  if @api_client.config.debugging
                    @api_client.config.logger.debug 'Calling API: ValidationRulesApi.delete_validation_rule_assignment ...'
                  end
                  # verify the required parameter 'validation_rule_id' is set
            Severity: Minor
            Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

              Method create_validation_rules_with_http_info has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private def create_validation_rules_with_http_info(opts = {})
                    if @api_client.config.debugging
                      @api_client.config.logger.debug 'Calling API: ValidationRulesApi.create_validation_rules ...'
                    end
                    # resource path
              Severity: Minor
              Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

                Method get_validation_rule_with_http_info has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private def get_validation_rule_with_http_info(validation_rule_id, opts = {})
                      if @api_client.config.debugging
                        @api_client.config.logger.debug 'Calling API: ValidationRulesApi.get_validation_rule ...'
                      end
                      # verify the required parameter 'validation_rule_id' is set
                Severity: Minor
                Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

                  Method delete_validation_rules_with_http_info has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private def delete_validation_rules_with_http_info(validation_rule_id, opts = {})
                        if @api_client.config.debugging
                          @api_client.config.logger.debug 'Calling API: ValidationRulesApi.delete_validation_rules ...'
                        end
                        # verify the required parameter 'validation_rule_id' is set
                  Severity: Minor
                  Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 1 hr to fix

                    Method update_validation_rule_with_http_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private def update_validation_rule_with_http_info(validation_rule_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.update_validation_rule ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Minor
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method delete_validation_rule_assignment_with_http_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private def delete_validation_rule_assignment_with_http_info(validation_rule_id, assignment_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.delete_validation_rule_assignment ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Minor
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 5 locations. Consider refactoring.
                    Open

                        private def list_validation_rules_with_http_info(opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules ...'
                          end
                          if @api_client.config.client_side_validation && !opts[:'limit'].nil? && opts[:'limit'] > 100
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 4 other locations - About 7 hrs to fix
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 658..716
                    lib/VoucherifySdk/api/products_api.rb on lines 577..635
                    lib/VoucherifySdk/api/promotions_api.rb on lines 501..559
                    lib/VoucherifySdk/api/validation_rules_api.rb on lines 468..526

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 228.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 5 locations. Consider refactoring.
                    Open

                        private def list_validation_rules_assignments_with_http_info(opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.list_validation_rules_assignments ...'
                          end
                          if @api_client.config.client_side_validation && !opts[:'page'].nil? && opts[:'page'] > 100
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 4 other locations - About 7 hrs to fix
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 658..716
                    lib/VoucherifySdk/api/products_api.rb on lines 577..635
                    lib/VoucherifySdk/api/promotions_api.rb on lines 501..559
                    lib/VoucherifySdk/api/validation_rules_api.rb on lines 384..442

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 228.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 15 locations. Consider refactoring.
                    Open

                        private def update_validation_rule_with_http_info(validation_rule_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.update_validation_rule ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 14 other locations - About 4 hrs to fix
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 507..557
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 736..786
                    lib/VoucherifySdk/api/categories_api.rb on lines 284..334
                    lib/VoucherifySdk/api/customers_api.rb on lines 625..675
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 39..89
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 447..497
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 1555..1605
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 1777..1827
                    lib/VoucherifySdk/api/orders_api.rb on lines 372..422
                    lib/VoucherifySdk/api/products_api.rb on lines 103..153
                    lib/VoucherifySdk/api/products_api.rb on lines 745..795
                    lib/VoucherifySdk/api/promotions_api.rb on lines 39..89
                    lib/VoucherifySdk/api/rewards_api.rb on lines 39..89
                    lib/VoucherifySdk/api/vouchers_api.rb on lines 229..279

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 150.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 6 locations. Consider refactoring.
                    Open

                        private def delete_validation_rule_assignment_with_http_info(validation_rule_id, assignment_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.delete_validation_rule_assignment ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 5 other locations - About 4 hrs to fix
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 109..156
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 242..289
                    lib/VoucherifySdk/api/promotions_api.rb on lines 109..156
                    lib/VoucherifySdk/api/rewards_api.rb on lines 170..217
                    lib/VoucherifySdk/api/vouchers_api.rb on lines 512..559

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 142.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 24 locations. Consider refactoring.
                    Open

                        private def get_validation_rule_with_http_info(validation_rule_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.get_validation_rule ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 23 other locations - About 3 hrs to fix
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 316..361
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 379..424
                    lib/VoucherifySdk/api/campaigns_api.rb on lines 442..487
                    lib/VoucherifySdk/api/categories_api.rb on lines 162..207
                    lib/VoucherifySdk/api/customers_api.rb on lines 101..146
                    lib/VoucherifySdk/api/customers_api.rb on lines 225..270
                    lib/VoucherifySdk/api/customers_api.rb on lines 455..500
                    lib/VoucherifySdk/api/exports_api.rb on lines 228..273
                    lib/VoucherifySdk/api/loyalties_api.rb on lines 1337..1382
                    lib/VoucherifySdk/api/orders_api.rb on lines 165..210
                    lib/VoucherifySdk/api/product_collections_api.rb on lines 162..207
                    lib/VoucherifySdk/api/products_api.rb on lines 305..350
                    lib/VoucherifySdk/api/products_api.rb on lines 368..413
                    lib/VoucherifySdk/api/promotions_api.rb on lines 235..280
                    lib/VoucherifySdk/api/promotions_api.rb on lines 298..343
                    lib/VoucherifySdk/api/promotions_api.rb on lines 430..475
                    lib/VoucherifySdk/api/promotions_api.rb on lines 577..622
                    lib/VoucherifySdk/api/promotions_api.rb on lines 640..685
                    lib/VoucherifySdk/api/redemptions_api.rb on lines 37..82
                    lib/VoucherifySdk/api/redemptions_api.rb on lines 100..145
                    lib/VoucherifySdk/api/vouchers_api.rb on lines 101..146
                    lib/VoucherifySdk/api/vouchers_api.rb on lines 164..209
                    lib/VoucherifySdk/api/vouchers_api.rb on lines 297..342

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 131.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        private def delete_validation_rules_with_http_info(validation_rule_id, opts = {})
                          if @api_client.config.debugging
                            @api_client.config.logger.debug 'Calling API: ValidationRulesApi.delete_validation_rules ...'
                          end
                          # verify the required parameter 'validation_rule_id' is set
                    Severity: Major
                    Found in lib/VoucherifySdk/api/validation_rules_api.rb and 7 other locations - About 3 hrs to fix
                    lib/VoucherifySdk/api/categories_api.rb on lines 101..144
                    lib/VoucherifySdk/api/customers_api.rb on lines 164..207
                    lib/VoucherifySdk/api/exports_api.rb on lines 101..144
                    lib/VoucherifySdk/api/product_collections_api.rb on lines 101..144
                    lib/VoucherifySdk/api/promotions_api.rb on lines 174..217
                    lib/VoucherifySdk/api/rewards_api.rb on lines 107..150
                    lib/VoucherifySdk/api/segments_api.rb on lines 37..80

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 122.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status