Sign upLogin

voucherifyio/voucherify-ruby-sdk

View on GitHub
Star
lib/VoucherifySdk/models/sku_with_product.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `VoucherifySdk::SkuWithProduct` initialize method"
      end
Severity: Minor
Found in lib/VoucherifySdk/models/sku_with_product.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File sku_with_product.rb has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'date'
require 'time'

module VoucherifySdk
  class SkuWithProduct
Severity: Minor
Found in lib/VoucherifySdk/models/sku_with_product.rb - About 3 hrs to fix

    Method initialize has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `VoucherifySdk::SkuWithProduct` initialize method"
      end
    Severity: Major
    Found in lib/VoucherifySdk/models/sku_with_product.rb - About 2 hrs to fix

      Method _deserialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self._deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
      Severity: Minor
      Found in lib/VoucherifySdk/models/sku_with_product.rb - About 1 hr to fix

        Method build_from_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.build_from_hash(attributes)
      return nil unless attributes.is_a?(Hash)
      attributes = attributes.transform_keys(&:to_sym)
      transformed_hash = {}
      openapi_types.each_pair do |key, type|
        Severity: Minor
        Found in lib/VoucherifySdk/models/sku_with_product.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _deserialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def self._deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
        Severity: Minor
        Found in lib/VoucherifySdk/models/sku_with_product.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method valid? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def valid?
      warn '[DEPRECATED] the `valid?` method is obsolete'
      return false if @id.nil?
      return false if @product_id.nil?
      return false if @attributes.nil?
        Severity: Minor
        Found in lib/VoucherifySdk/models/sku_with_product.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method to_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def to_hash
      hash = {}
      self.class.attribute_map.each_pair do |attr, param|
        value = self.send(attr)
        if value.nil?
        Severity: Minor
        Found in lib/VoucherifySdk/models/sku_with_product.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return false if @created_at.nil?
        Severity: Major
        Found in lib/VoucherifySdk/models/sku_with_product.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return false unless object_validator.valid?(@object)
          Severity: Major
          Found in lib/VoucherifySdk/models/sku_with_product.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return false if @object.nil?
            Severity: Major
            Found in lib/VoucherifySdk/models/sku_with_product.rb - About 30 mins to fix

              Method list_invalid_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def list_invalid_properties
      warn '[DEPRECATED] the `list_invalid_properties` method is obsolete'
      invalid_properties = Array.new
      if @id.nil?
        invalid_properties.push('invalid value for "id", id cannot be nil.')
              Severity: Minor
              Found in lib/VoucherifySdk/models/sku_with_product.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _to_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _to_hash(value)
      if value.is_a?(Array)
        value.compact.map { |v| _to_hash(v) }
      elsif value.is_a?(Hash)
        {}.tap do |hash|
              Severity: Minor
              Found in lib/VoucherifySdk/models/sku_with_product.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 12 locations. Consider refactoring.
              Open

                  def ==(o)
      return true if self.equal?(o)
      self.class == o.class &&
          id == o.id &&
          source_id == o.source_id &&
              Severity: Major
              Found in lib/VoucherifySdk/models/sku_with_product.rb and 11 other locations - About 2 hrs to fix
              lib/VoucherifySdk/models/campaigns_import_voucher_item.rb on lines 230..246
              lib/VoucherifySdk/models/campaigns_update_coupon_campaign_base.rb on lines 237..253
              lib/VoucherifySdk/models/list_publications_item_invalid.rb on lines 311..327
              lib/VoucherifySdk/models/product_collections_create_dynamic_request_body_filter.rb on lines 208..224
              lib/VoucherifySdk/models/promotion_tier_create_params.rb on lines 201..217
              lib/VoucherifySdk/models/redemption_reward_result.rb on lines 252..268
              lib/VoucherifySdk/models/simple_campaign.rb on lines 237..253
              lib/VoucherifySdk/models/simple_redemption.rb on lines 224..240
              lib/VoucherifySdk/models/simple_redemption_reward_result.rb on lines 236..252
              lib/VoucherifySdk/models/simple_voucher.rb on lines 246..262
              lib/VoucherifySdk/models/voucher_transaction_details.rb on lines 179..195

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 24 locations. Consider refactoring.
              Open

                  def self.openapi_types
      {
        :'id' => :'String',
        :'source_id' => :'String',
        :'product_id' => :'String',
              Severity: Major
              Found in lib/VoucherifySdk/models/sku_with_product.rb and 23 other locations - About 25 mins to fix
              lib/VoucherifySdk/models/campaigns_import_voucher_item.rb on lines 76..90
              lib/VoucherifySdk/models/campaigns_import_voucher_item.rb on lines 100..114
              lib/VoucherifySdk/models/campaigns_update_coupon_campaign_base.rb on lines 80..94
              lib/VoucherifySdk/models/campaigns_update_coupon_campaign_base.rb on lines 104..118
              lib/VoucherifySdk/models/list_publications_item_invalid.rb on lines 79..93
              lib/VoucherifySdk/models/list_publications_item_invalid.rb on lines 103..117
              lib/VoucherifySdk/models/product_collections_create_dynamic_request_body_filter.rb on lines 68..82
              lib/VoucherifySdk/models/product_collections_create_dynamic_request_body_filter.rb on lines 92..106
              lib/VoucherifySdk/models/promotion_tier_create_params.rb on lines 57..71
              lib/VoucherifySdk/models/promotion_tier_create_params.rb on lines 81..95
              lib/VoucherifySdk/models/redemption_reward_result.rb on lines 75..89
              lib/VoucherifySdk/models/redemption_reward_result.rb on lines 99..113
              lib/VoucherifySdk/models/simple_campaign.rb on lines 78..92
              lib/VoucherifySdk/models/simple_campaign.rb on lines 102..116
              lib/VoucherifySdk/models/simple_redemption.rb on lines 76..90
              lib/VoucherifySdk/models/simple_redemption.rb on lines 100..114
              lib/VoucherifySdk/models/simple_redemption_reward_result.rb on lines 76..90
              lib/VoucherifySdk/models/simple_redemption_reward_result.rb on lines 100..114
              lib/VoucherifySdk/models/simple_voucher.rb on lines 78..92
              lib/VoucherifySdk/models/simple_voucher.rb on lines 102..116
              lib/VoucherifySdk/models/sku_with_product.rb on lines 79..93
              lib/VoucherifySdk/models/voucher_transaction_details.rb on lines 46..60
              lib/VoucherifySdk/models/voucher_transaction_details.rb on lines 70..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 24 locations. Consider refactoring.
              Open

                  def self.attribute_map
      {
        :'id' => :'id',
        :'source_id' => :'source_id',
        :'product_id' => :'product_id',
              Severity: Major
              Found in lib/VoucherifySdk/models/sku_with_product.rb and 23 other locations - About 25 mins to fix
              lib/VoucherifySdk/models/campaigns_import_voucher_item.rb on lines 76..90
              lib/VoucherifySdk/models/campaigns_import_voucher_item.rb on lines 100..114
              lib/VoucherifySdk/models/campaigns_update_coupon_campaign_base.rb on lines 80..94
              lib/VoucherifySdk/models/campaigns_update_coupon_campaign_base.rb on lines 104..118
              lib/VoucherifySdk/models/list_publications_item_invalid.rb on lines 79..93
              lib/VoucherifySdk/models/list_publications_item_invalid.rb on lines 103..117
              lib/VoucherifySdk/models/product_collections_create_dynamic_request_body_filter.rb on lines 68..82
              lib/VoucherifySdk/models/product_collections_create_dynamic_request_body_filter.rb on lines 92..106
              lib/VoucherifySdk/models/promotion_tier_create_params.rb on lines 57..71
              lib/VoucherifySdk/models/promotion_tier_create_params.rb on lines 81..95
              lib/VoucherifySdk/models/redemption_reward_result.rb on lines 75..89
              lib/VoucherifySdk/models/redemption_reward_result.rb on lines 99..113
              lib/VoucherifySdk/models/simple_campaign.rb on lines 78..92
              lib/VoucherifySdk/models/simple_campaign.rb on lines 102..116
              lib/VoucherifySdk/models/simple_redemption.rb on lines 76..90
              lib/VoucherifySdk/models/simple_redemption.rb on lines 100..114
              lib/VoucherifySdk/models/simple_redemption_reward_result.rb on lines 76..90
              lib/VoucherifySdk/models/simple_redemption_reward_result.rb on lines 100..114
              lib/VoucherifySdk/models/simple_voucher.rb on lines 78..92
              lib/VoucherifySdk/models/simple_voucher.rb on lines 102..116
              lib/VoucherifySdk/models/sku_with_product.rb on lines 103..117
              lib/VoucherifySdk/models/voucher_transaction_details.rb on lines 46..60
              lib/VoucherifySdk/models/voucher_transaction_details.rb on lines 70..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status