Sign upLogin

voucherifyio/voucherify-ruby-sdk

View on GitHub
Star
lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb

Summary

Maintainability
D
2 days
Test Coverage

Method find_and_cast_into_type has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

      def find_and_cast_into_type(klass, data)
        return if data.nil?

        case klass.to_s
        when 'Boolean'
Severity: Minor
Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_and_cast_into_type has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def find_and_cast_into_type(klass, data)
        return if data.nil?

        case klass.to_s
        when 'Boolean'
Severity: Minor
Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 1 hr to fix

    Method build has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def build(data)
        # Go through the list of oneOf items and attempt to identify the appropriate one.
        # Note:
        # - We do not attempt to check whether exactly one item matches.
        # - No advanced validation of types in some cases (e.g. "x: { type: string }" will happily match { x: 123 })
    Severity: Minor
    Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

              return data if data.instance_of?(String)
    Severity: Major
    Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                    return model if model
      Severity: Major
      Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return data.map { |item| find_and_cast_into_type(sub_type, item) }
        Severity: Major
        Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return data.each_with_object({}) { |(k, v), hsh| hsh[k] = find_and_cast_into_type(sub_type, v) }
          Severity: Major
          Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                          return model if model
            Severity: Major
            Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return Time.parse(data)
              Severity: Major
              Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return Date.parse(data)
                Severity: Major
                Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                            return data if data.instance_of?(Hash)
                  Severity: Major
                  Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb - About 30 mins to fix

                    Similar blocks of code found in 6 locations. Consider refactoring.
                    Open

                    module VoucherifySdk
  module ValidationsValidateAllResponseBodyRedeemablesItem
    class << self
      # List of class defined in oneOf (OpenAPI v3)
      def openapi_one_of
                    Severity: Major
                    Found in lib/VoucherifySdk/models/validations_validate_all_response_body_redeemables_item.rb and 5 other locations - About 7 hrs to fix
                    lib/VoucherifySdk/models/array_inner.rb on lines 16..101
                    lib/VoucherifySdk/models/earning_rule_proportional_order.rb on lines 16..101
                    lib/VoucherifySdk/models/earning_rule_proportional_order_items.rb on lines 16..101
                    lib/VoucherifySdk/models/publications_list_response_body_publications_item.rb on lines 16..102
                    lib/VoucherifySdk/models/reward_type.rb on lines 16..101

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 227.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status