Sign upLogin

voucherifyio/voucherify-ruby-sdk

View on GitHub
Star
lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `VoucherifySdk::VouchersRedemptionGetResponseBody` initialize method"
      end
Severity: Minor
Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(attributes = {})
      if (!attributes.is_a?(Hash))
        fail ArgumentError, "The input argument (attributes) must be a hash in `VoucherifySdk::VouchersRedemptionGetResponseBody` initialize method"
      end
Severity: Minor
Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 1 hr to fix

    Method _deserialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self._deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
    Severity: Minor
    Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 1 hr to fix

      Method build_from_hash has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.build_from_hash(attributes)
      return nil unless attributes.is_a?(Hash)
      attributes = attributes.transform_keys(&:to_sym)
      transformed_hash = {}
      openapi_types.each_pair do |key, type|
      Severity: Minor
      Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _deserialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def self._deserialize(type, value)
      case type.to_sym
      when :Time
        Time.parse(value)
      when :Date
      Severity: Minor
      Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_hash has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_hash
      hash = {}
      self.class.attribute_map.each_pair do |attr, param|
        value = self.send(attr)
        if value.nil?
      Severity: Minor
      Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return false if @redemption_entries.nil?
      Severity: Major
      Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return false if @total.nil?
        Severity: Major
        Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 30 mins to fix

          Method list_invalid_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def list_invalid_properties
      warn '[DEPRECATED] the `list_invalid_properties` method is obsolete'
      invalid_properties = Array.new
      if @redeemed_quantity.nil?
        invalid_properties.push('invalid value for "redeemed_quantity", redeemed_quantity cannot be nil.')
          Severity: Minor
          Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method valid? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def valid?
      warn '[DEPRECATED] the `valid?` method is obsolete'
      return false if @redeemed_quantity.nil?
      return false if @object.nil?
      return false if @url.nil?
          Severity: Minor
          Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _to_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _to_hash(value)
      if value.is_a?(Array)
        value.compact.map { |v| _to_hash(v) }
      elsif value.is_a?(Hash)
        {}.tap do |hash|
          Severity: Minor
          Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def valid?
      warn '[DEPRECATED] the `valid?` method is obsolete'
      return false if @redeemed_quantity.nil?
      return false if @object.nil?
      return false if @url.nil?
          Severity: Minor
          Found in lib/VoucherifySdk/models/vouchers_redemption_get_response_body.rb and 2 other locations - About 35 mins to fix
          lib/VoucherifySdk/models/loyalty_card_transaction.rb on lines 232..240
          lib/VoucherifySdk/models/voucher_transaction.rb on lines 225..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status