vpietri/magento2-developer-quickdevbar

View on GitHub
Block/Adminhtml/System/Config/Form/Fieldset/IsEnabled.php

Summary

Maintainability
A
25 mins
Test Coverage

Function _getElementHtml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _getElementHtml(AbstractElement $element)
    {
        $html = [];
        if ($this->_qdbHelper->isToolbarAccessAllowed(true)) {
            $html[] = __('Yep');
Severity: Minor
Found in Block/Adminhtml/System/Config/Form/Fieldset/IsEnabled.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$element'.
Open

    protected function _getElementHtml(AbstractElement $element)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The property $_qdbHelper is not named in camelCase.
Open

class IsEnabled extends \Magento\Config\Block\System\Config\Form\Field
{
    /**
     * @var \ADM\QuickDevBar\Helper\Data
     */

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The method _getElementHtml is not named in camelCase.
Open

    protected function _getElementHtml(AbstractElement $element)
    {
        $html = [];
        if ($this->_qdbHelper->isToolbarAccessAllowed(true)) {
            $html[] = __('Yep');

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status