Sign upLogin

vpietri/magento2-developer-quickdevbar

View on GitHub
Star
Console/Command/AbstractStatusToolbar.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method execute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {

        $this->resourceConfig->saveConfig('dev/quickdevbar/enable', $this->status);
        $output->writeln("<info>" . $this->message . "</info>");
Severity: Minor
Found in Console/Command/AbstractStatusToolbar.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(Config                $resourceConfig,
                                Manager               $cacheManager,
                                EventManagerInterface $eventManager,
                                Writer                $writer,
                                ArrayManager          $arrayManager,
    Severity: Minor
    Found in Console/Command/AbstractStatusToolbar.php - About 45 mins to fix

      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
    {

        $this->resourceConfig->saveConfig('dev/quickdevbar/enable', $this->status);
        $output->writeln("<info>" . $this->message . "</info>");
      Severity: Minor
      Found in Console/Command/AbstractStatusToolbar.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused parameters such as '$input'.
      Open

          protected function getProfilerClass(InputInterface $input)
      Severity: Minor
      Found in Console/Command/AbstractStatusToolbar.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      There are no issues that match your filters.

      Category
      Status