vpietri/magento2-developer-quickdevbar

View on GitHub
Controller/Action/ConfigUpdate.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function execute has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {

        $error = false;
        $output = '';
Severity: Minor
Found in Controller/Action/ConfigUpdate.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute()
    {

        $error = false;
        $output = '';
Severity: Major
Found in Controller/Action/ConfigUpdate.php - About 3 hrs to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            \Magento\Framework\App\Action\Context $context,
            \ADM\QuickDevBar\Helper\Data $qdbHelper,
            \Magento\Framework\Controller\Result\RawFactory $resultRawFactory,
            \Magento\Framework\View\LayoutFactory $layoutFactory,
            \Magento\Config\Model\ResourceModel\Config $resourceConfig,
    Severity: Major
    Found in Controller/Action/ConfigUpdate.php - About 50 mins to fix

      The method execute() has an NPath complexity of 4610. The configured NPath complexity threshold is 200.
      Open

          public function execute()
          {
      
              $error = false;
              $output = '';
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method execute() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
      Open

          public function execute()
          {
      
              $error = false;
              $output = '';
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '66', column '27').
      Open

                      throw new \Exception('Scope is missing');
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '59', column '27').
      Open

                      throw new \Exception('Key is missing');
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '79', column '39').
      Open

                                  throw new \Exception('Scope auto is unrecognized');
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid excessively long variable names like $_resultForwardFactory. Keep variable name length under 20.
      Open

          protected $_resultForwardFactory;
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      The property $_resultForwardFactory is not named in camelCase.
      Open

      class ConfigUpdate extends \ADM\QuickDevBar\Controller\Index
      {
          /**
           * @var \Magento\Config\Model\Resource\Config
           */
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
          protected $property_name;
      }

      Source

      The property $_resourceConfig is not named in camelCase.
      Open

      class ConfigUpdate extends \ADM\QuickDevBar\Controller\Index
      {
          /**
           * @var \Magento\Config\Model\Resource\Config
           */
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
          protected $property_name;
      }

      Source

      The property $_storeManager is not named in camelCase.
      Open

      class ConfigUpdate extends \ADM\QuickDevBar\Controller\Index
      {
          /**
           * @var \Magento\Config\Model\Resource\Config
           */
      Severity: Minor
      Found in Controller/Action/ConfigUpdate.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
          protected $property_name;
      }

      Source

      There are no issues that match your filters.

      Category
      Status