vpietri/magento2-developer-quickdevbar

View on GitHub
Observer/LayoutGenerateBlocksAfterObserver.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function buildTreeBlocks has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function buildTreeBlocks($layout, $name = 'root', $alias = '')
    {
        $element = $this->getElementByName($name);
        if ($element) {
            $treeBlocks = [
Severity: Minor
Found in Observer/LayoutGenerateBlocksAfterObserver.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildTreeBlocks has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function buildTreeBlocks($layout, $name = 'root', $alias = '')
    {
        $element = $this->getElementByName($name);
        if ($element) {
            $treeBlocks = [
Severity: Minor
Found in Observer/LayoutGenerateBlocksAfterObserver.php - About 1 hr to fix

    Function getTreeBlocksHierarchy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getTreeBlocksHierarchy($layout)
        {
            //$layout = $this->getLayout();
    
            $reflection = new \ReflectionClass($layout);
    Severity: Minor
    Found in Observer/LayoutGenerateBlocksAfterObserver.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '135', column '44').
    Open

                        $reflectionClass = new \ReflectionClass($block);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '74', column '27').
    Open

            $reflection = new \ReflectionClass($layout);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid assigning values to variables in if clauses and the like (line '81', column '12').
    Open

        public function getTreeBlocksHierarchy($layout)
        {
            //$layout = $this->getLayout();
    
            $reflection = new \ReflectionClass($layout);

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    TODO found
    Open

         * TODO: Find a better way to access the layout structure

    The property $_elements is not named in camelCase.
    Open

    class LayoutGenerateBlocksAfterObserver implements ObserverInterface
    {
    
        private $_elements = [];
    
    

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
        protected $property_name;
    }

    Source

    There are no issues that match your filters.

    Category
    Status