Sign upLogin

vpietri/magento2-developer-quickdevbar

View on GitHub
Star
Plugin/Framework/App/Cache.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method beforeSave has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        CacheInterface $subject,
        string $data,
        string $identifier,
        array $tags = [],
        $lifeTime = null
Severity: Minor
Found in Plugin/Framework/App/Cache.php - About 35 mins to fix

    Avoid unused parameters such as '$data'.
    Open

            string $data,
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$subject'.
    Open

        public function beforeLoad(CacheInterface $subject, string $identifier)
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$subject'.
    Open

            CacheInterface $subject,
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$subject'.
    Open

        public function beforeRemove(CacheInterface $subject, string $identifier)
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$tags'.
    Open

            array $tags = [],
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$lifeTime'.
    Open

            $lifeTime = null
    Severity: Minor
    Found in Plugin/Framework/App/Cache.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php
namespace ADM\QuickDevBar\Plugin\Framework\App;

use Magento\Framework\App\CacheInterface;
    Severity: Major
    Found in Plugin/Framework/App/Cache.php and 1 other location - About 2 hrs to fix
    Plugin/PageCache/FrontController/BuiltinPlugin.php on lines 1..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status