vpietri/magento2-developer-quickdevbar

View on GitHub
Service/Sql.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function initSqlProfilerData has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function initSqlProfilerData()
    {
        $longestQueryTime = 0;
        $shortestQueryTime = 100000;
        $longestQuery = '';
Severity: Minor
Found in Service/Sql.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initSqlProfilerData has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function initSqlProfilerData()
    {
        $longestQueryTime = 0;
        $shortestQueryTime = 100000;
        $longestQuery = '';
Severity: Major
Found in Service/Sql.php - About 2 hrs to fix

    Method computeQueryGrade has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function computeQueryGrade($allQueries, $shortestQueryTime, $longestQueryTime, $totalNumQueries, $average)
    Severity: Minor
    Found in Service/Sql.php - About 35 mins to fix

      Function computeQueryGrade has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function computeQueryGrade($allQueries, $shortestQueryTime, $longestQueryTime, $totalNumQueries, $average)
          {
              $squareSum = 0;
              foreach ($allQueries as $index => $query) {
                  $squareSum = pow($query['time'] - $average, 2);
      Severity: Minor
      Found in Service/Sql.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method initSqlProfilerData() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          protected function initSqlProfilerData()
          {
              $longestQueryTime = 0;
              $shortestQueryTime = 100000;
              $longestQuery = '';
      Severity: Minor
      Found in Service/Sql.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '42', column '38').
      Open

                  $this->sqlProfiler = new \Zend_Db_Profiler();
      Severity: Minor
      Found in Service/Sql.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There are no issues that match your filters.

      Category
      Status