Sign upLogin

vshn/k8up

View on GitHub
Star
cmd/cli/main.go

Summary

Maintainability
C
1 day
Test Coverage

Function RunRestore has 136 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func RunRestore(ctx *cli.Context) error {
    var restoreName, snapshot string
    var s3, pvc v1.RestoreMethod
    logger := cmd.AppLogger(ctx).WithName("cli-restore")
Severity: Major
Found in cmd/cli/main.go - About 4 hrs to fix

    Function RunRestore has 8 return statements (exceeds 4 allowed).
    Open

    func RunRestore(ctx *cli.Context) error {
    var restoreName, snapshot string
    var s3, pvc v1.RestoreMethod
    logger := cmd.AppLogger(ctx).WithName("cli-restore")
    Severity: Major
    Found in cmd/cli/main.go - About 50 mins to fix

      Function RunRestore has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func RunRestore(ctx *cli.Context) error {
    var restoreName, snapshot string
    var s3, pvc v1.RestoreMethod
    logger := cmd.AppLogger(ctx).WithName("cli-restore")
      Severity: Minor
      Found in cmd/cli/main.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          S3: &v1.S3Spec{
                        Endpoint: restore.Cfg.S3Endpoint,
                        Bucket:   restore.Cfg.S3Bucket,
                        AccessKeyIDSecretRef: &corev1.SecretKeySelector{
                            Key: restore.Cfg.S3SecretRefUsernameKey,
      Severity: Major
      Found in cmd/cli/main.go and 1 other location - About 1 hr to fix
      cmd/cli/main.go on lines 279..294

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              S3: &v1.S3Spec{
            Endpoint: restore.Cfg.RestoreToS3Endpoint,
            Bucket:   restore.Cfg.RestoreToS3Bucket,
            AccessKeyIDSecretRef: &corev1.SecretKeySelector{
                Key: restore.Cfg.RestoreToS3SecretUsernameKey,
      Severity: Major
      Found in cmd/cli/main.go and 1 other location - About 1 hr to fix
      cmd/cli/main.go on lines 324..339

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status