Sign upLogin

vshn/k8up

View on GitHub
Star
cmd/restic/main.go

Summary

Maintainability
A
3 hrs
Test Coverage
F
41%

Function doNonBackupTasks has 5 return statements (exceeds 4 allowed).
Open

func doNonBackupTasks(resticCLI *resticCli.Restic) error {
    if err := doPrune(resticCLI); err != nil {
        return err
    }
Severity: Major
Found in cmd/restic/main.go - About 35 mins to fix

    Function backupAnnotatedPods has 5 return statements (exceeds 4 allowed).
    Open

    func backupAnnotatedPods(ctx context.Context, resticCLI *resticCli.Restic, mainLogger logr.Logger) error {
    _, serviceErr := os.Stat("/var/run/secrets/kubernetes.io")
    _, kubeconfigErr := os.Stat(cfg.Config.KubeConfig)

    if serviceErr != nil && kubeconfigErr != nil {
    Severity: Major
    Found in cmd/restic/main.go - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          restoreOptions := resticCli.RestoreOptions{
        RestoreType:   resticCli.RestoreType(cfg.Config.RestoreType),
        RestoreDir:    cfg.Config.RestoreDir,
        RestoreFilter: cfg.Config.RestoreFilter,
        Verify:        cfg.Config.VerifyRestore,
      Severity: Major
      Found in cmd/restic/main.go and 1 other location - About 1 hr to fix
      cmd/restic/main.go on lines 218..229

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          restoreOptions := resticCli.RestoreOptions{
        RestoreType:   resticCli.RestoreType(cfg.Config.RestoreType),
        RestoreDir:    cfg.Config.RestoreDir,
        RestoreFilter: cfg.Config.RestoreFilter,
        Verify:        cfg.Config.VerifyRestore,
      Severity: Major
      Found in cmd/restic/main.go and 1 other location - About 1 hr to fix
      cmd/restic/main.go on lines 243..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status