waku-org/go-waku

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    go func() {
        defer wg.Done()

        ticker := time.NewTimer(30 * time.Second)
        defer ticker.Stop()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    go func() {
        defer wg.Done()

        ticker := time.NewTimer(30 * time.Second)
        defer ticker.Stop()

• Read up
  Read up

Function NewDynamicGroupManager has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

    ethClientAddr string,
    memContractAddr common.Address,
    membershipIndexToLoad *uint,
    appKeystore *keystore.AppKeystore,
    keystorePassword string,

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    if c.options.RLNRelay.Enable {
        err = c.node.RLNRelay().AppendRLNProof(wakuMsg, c.node.Timesource().Now())
        if err != nil {
            return err
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    if c.options.RLNRelay.Enable {
        // for future version when we support more than one rln protected content topic,
        // we should check the message content topic as well
        err = c.node.RLNRelay().AppendRLNProof(wakuMsg, c.node.Timesource().Now())
        if err != nil {

• Read up
  Read up

Method Chat.parseInput has 11 return statements (exceeds 4 allowed).

Open

func (c *Chat) parseInput() {
    defer c.wg.Done()

    var disconnectedPeers []peer.ID

Method DB.prepareStmts has 11 return statements (exceeds 4 allowed).

Open

func (db *DB) prepareStmts() error {
    stmt, err := db.db.Prepare("INSERT INTO registrations VALUES (NULL, ?, ?, ?, ?)")
    if err != nil {
        return err
    }

Function getStoreParams has 11 return statements (exceeds 4 allowed).

Open

func getStoreParams(r *http.Request) (store.Criteria, []store.RequestOption, error) {
    var options []store.RequestOption
    var err error
    peerAddrStr := r.URL.Query().Get("peerAddr")
    var m multiaddr.Multiaddr

Method Chat.publish has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *Chat) publish(ctx context.Context, message string) error {
    msg := &pb.Chat2Message{
        Timestamp: uint64(c.node.Timesource().Now().Unix()),
        Nick:      c.nick,
        Payload:   []byte(message),

Function TestWakuLightPushCornerCases has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func TestWakuLightPushCornerCases(t *testing.T) {
    ctx, cancel := context.WithCancel(context.Background())
    defer cancel()

    testTopic := "/waku/2/go/lightpush/test"

Method WakuFilterLightNode.onRequest has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (wf *WakuFilterLightNode) onRequest(ctx context.Context) func(network.Stream) {
    return func(stream network.Stream) {
        peerID := stream.Conn().RemotePeer()

        logger := wf.log.With(logging.HostID("peerID", peerID))

Method DB.prepareStmts has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (db *DB) prepareStmts() error {
    stmt, err := db.db.Prepare("INSERT INTO registrations VALUES (NULL, ?, ?, ?, ?)")
    if err != nil {
        return err
    }

Function Multiaddress has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func Multiaddress(node *enode.Node) (peer.ID, []multiaddr.Multiaddr, error) {
    pubKey := utils.EcdsaPubKeyToSecp256k1PublicKey(node.Pubkey())
    peerID, err := peer.IDFromPublicKey(pubKey)
    if err != nil {
        return "", nil, err

Method WakuLightPush.handleOpts has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (wakuLP *WakuLightPush) handleOpts(ctx context.Context, message *wpb.WakuMessage, opts ...RequestOption) (*lightPushRequestParameters, error) {
    params := new(lightPushRequestParameters)
    params.host = wakuLP.h
    params.log = wakuLP.log
    params.pm = wakuLP.pm

Function rlnFlags has 51 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func rlnFlags() []cli.Flag {
    return []cli.Flag{
        &cli.BoolFlag{
            Name:        "rln-relay",
            Value:       false,

Method HistoryRetriever.createMessagesRequest has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    ctx context.Context,
    peerID peer.ID,
    criteria store.FilterCriteria,
    cursor []byte,
    limit uint64,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if evt.Type == pubsub.PeerJoin {
            w.log.Debug("received a PeerJoin event", zap.String("topic", topic), logging.HostID("peerID", evt.Peer))
            err = w.emitters.EvtPeerTopic.Emit(EvtPeerTopic{PubsubTopic: topic, PeerID: evt.Peer, State: PEER_JOINED})
            if err != nil {
                w.log.Error("failed to emit PeerJoin", zap.String("topic", topic), zap.Error(err))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        } else if evt.Type == pubsub.PeerLeave {
            w.log.Debug("received a PeerLeave event", zap.String("topic", topic), logging.HostID("peerID", evt.Peer))
            err = w.emitters.EvtPeerTopic.Emit(EvtPeerTopic{PubsubTopic: topic, PeerID: evt.Peer, State: PEER_LEFT})
            if err != nil {
                w.log.Error("failed to emit PeerLeave", zap.String("topic", topic), zap.Error(err))

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func (m UI) breaklineIfNeeded(i int, mt MessageType) string {
    result := ""
    if i > 0 {
        if (mt == ChatMessageType && m.messages[i-1].mType != ChatMessageType) || (mt != ChatMessageType && m.messages[i-1].mType == ChatMessageType) {
            result += "\n"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func (m UI) breaklineIfNeeded(i int, mt MessageType) string {
    result := ""
    if i > 0 {
        if (mt == ChatMessageType && m.messages[i-1].mType != ChatMessageType) || (mt != ChatMessageType && m.messages[i-1].mType == ChatMessageType) {
            result += "\n"

• Read up
  Read up