waku-org/go-waku

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func waku_decode_asymmetric(messageJSON *C.char, privateKey *C.char, cb C.WakuCallBack, userData unsafe.Pointer) C.int {
    return singleFnExecNoCtx(func() (string, error) {
        return library.DecodeAsymmetric(C.GoString(messageJSON), C.GoString(privateKey))
    }, cb, userData)
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                lbl.text =
                    (lbl.text.toString() + ">>> Addresses: " + it.addrs.joinToString(",") + "\n")

• Read up
  Read up

Function NewLocalnode has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewLocalnode(priv *ecdsa.PrivateKey, ipAddr *net.TCPAddr, udpPort int, wakuFlags wenr.WakuEnrBitfield, advertiseAddr *net.IP, log *zap.Logger) (*enode.LocalNode, error) {

Function NewFilterManager has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewFilterManager(ctx context.Context, logger *zap.Logger, minPeersPerFilter int, envProcessor EnevelopeProcessor, node *filter.WakuFilterLightNode, opts ...SubscribeOptions) *FilterManager {

Function computeOffset has 7 return statements (exceeds 4 allowed).

Open

func computeOffset(timeQuery ntpQuery, servers []string, allowedFailures int) (time.Duration, error) {
    if len(servers) == 0 {
        return 0, nil
    }
    responses := make(chan queryResponse, len(servers))

Avoid deeply nested control flow statements.

Open

                if err := pm.metadata.DisconnectPeerOnShardMismatch(ctx, peerEvt.PeerID); err != nil {
                    return
                }

Method HistoryRetriever.Query has 7 return statements (exceeds 4 allowed).

Open

func (hr *HistoryRetriever) Query(
    ctx context.Context,
    criteria store.FilterCriteria,
    storenodeID peer.ID,
    pageLimit uint64,

Method StaticShardingPubsubTopic.Parse has 7 return statements (exceeds 4 allowed).

Open

func (s *StaticShardingPubsubTopic) Parse(topic string) error {
    if !strings.HasPrefix(topic, StaticShardingPubsubTopicPrefix) {
        return ErrInvalidShardedTopicPrefix
    }

Method HistoryRetriever.requestStoreMessages has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (hr *HistoryRetriever) requestStoreMessages(ctx context.Context, peerID peer.ID, criteria store.FilterCriteria, cursor []byte, limit uint64, processEnvelopes bool) ([]byte, int, error) {

Method AppKeystore.GetMembershipCredentials has 7 return statements (exceeds 4 allowed).

Open

func (k *AppKeystore) GetMembershipCredentials(keystorePassword string, index *rln.MembershipIndex, filterMembershipContract MembershipContractInfo) (*MembershipCredentials, error) {
    // If there is only one, and index to laod nil, assume 0,
    // if there is more than one, complain if the index to load is nil

    var key Key

Function NewStaticGroupManager has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    group []rln.IDCommitment,
    identityCredential rln.IdentityCredential,
    index rln.MembershipIndex,
    rlnInstance *rln.RLN,
    rootTracker *group_manager.MerkleRootTracker,

Avoid deeply nested control flow statements.

Open

                            if err != nil {
                                c.ui.ErrorMessage(err)
                                return
                            }

Avoid deeply nested control flow statements.

Open

                            if err != nil {
                                c.ui.ErrorMessage(err)
                                return
                            }

Method HistoryRetriever.Query has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    ctx context.Context,
    criteria store.FilterCriteria,
    storenodeID peer.ID,
    pageLimit uint64,
    shouldProcessNextPage func(int) (bool, uint64),

Function execute has 7 return statements (exceeds 4 allowed).

Open

func execute(options Options) {
    var err error
    hostAddr, _ := net.ResolveTCPAddr("tcp", fmt.Sprintf("0.0.0.0:%d", options.Port))

    if options.NodeKey == nil {

Function NewPeerManager has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func NewPeerManager(maxConnections int, maxPeers int, metadata *metadata.WakuMetadata, relay *relay.WakuRelay, relayEnabled bool, logger *zap.Logger) *PeerManager {

Method WakuNode.AddDiscoveredPeer has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func (w *WakuNode) AddDiscoveredPeer(ID peer.ID, addrs []ma.Multiaddr, origin wps.Origin, pubsubTopics []string, enr *enode.Node, connectNow bool) {

Avoid deeply nested control flow statements.

Open

                            if _, ok := meshPeersSet[p]; !ok {
                                relayPeersSet[p] = struct{}{}
                            }

Function Subscribe has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func Subscribe(ctx context.Context, wf *filter.WakuFilterLightNode, contentFilter protocol.ContentFilter, config FilterConfig, log *zap.Logger, params *subscribeParameters) (*Sub, error) {

Avoid deeply nested control flow statements.

Open

                    if prevNodeVal == "" {
                        w.log.Info("local node enr record", logging.ENode("enr", w.localNode.Node()))
                    } else {
                        w.log.Info("local node new enr record", logging.ENode("enr", w.localNode.Node()))
                    }