wavesoftware/puppet-xtreemfs

View on GitHub
lib/puppet/provider/xtreemfs_volume/xtreemfs.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method options has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def options type
    opts = []
    if resource[:options]
      resource[:options].keys.sort.each do |key|
        value = resource[:options][key]
Severity: Minor
Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method uuid has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def uuid
    if @property_hash[:uuid]
      @property_hash[:uuid]
    else
      volumes = self.class.parse lsfs
Severity: Minor
Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method rawinstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.rawinstances
    unless self.instances_raw
      fqdn = Facter.value :fqdn
      if self.is_port_open?(fqdn, 32636)
        volumes = lsfs_xtreemfs fqdn
Severity: Minor
Found in lib/puppet/provider/xtreemfs_volume/xtreemfs.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status