Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/auth/reactors/AuthSigninReactor.swift

Summary

Maintainability
A
0 mins
Test Coverage

Function mutate has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // email
        case let .updateEmail(email):
            return .just(.updateEmail(email))
Severity: Major
Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift - About 2 hrs to fix

    Function reduce has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        func reduce(state: State, mutation: Mutation) -> State {
        var state = state
        switch mutation {
        // update login
        case let .updateEmail(email):
    Severity: Minor
    Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift - About 1 hr to fix

      Function mutate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // email
        case let .updateEmail(email):
            return .just(.updateEmail(email))
      Severity: Minor
      Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Wontfix

                  return .just(.goSignUp)
      Severity: Major
      Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                        self.provider.authService
                    .signIn(email: self.currentState.user.email, password: self.currentState.user.password ?? "")
                    .map { result in
                        switch result {
                        case let .success(response):
        Severity: Major
        Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift and 1 other location - About 1 hr to fix
        waosSwift/modules/auth/reactors/AuthSigninReactor.swift on lines 115..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                        self.provider.authService
                    .oauth(strategy: false, key: "sub", value: sub, firstName: firstName, lastName: lastName, email: email)
                    .map { result in
                        switch result {
                        case let .success(response):
        Severity: Major
        Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift and 1 other location - About 1 hr to fix
        waosSwift/modules/auth/reactors/AuthSigninReactor.swift on lines 95..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 4 locations. Consider refactoring.
        Wontfix

        /**
 * Dependencies
 */

import UIKit
        Severity: Major
        Found in waosSwift/modules/auth/reactors/AuthSigninReactor.swift and 3 other locations - About 1 hr to fix
        waosSwift/modules/auth/reactors/AuthForgotReactor.swift on lines 1..157
        waosSwift/modules/auth/reactors/AuthSignupReactor.swift on lines 1..210
        waosSwift/modules/users/reactors/UserViewReactor.swift on lines 1..269

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status