weareopensource/Swift

View on GitHub
waosSwift/modules/tasks/controllers/TasksListController.swift

Summary

Maintainability
A
2 hrs
Test Coverage

Function bindState has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func bindState(_ reactor: TasksListReactor) {
        // tasks
        reactor.state
            .map { $0.sections }
            .bind(to: self.tableView.rx.items(dataSource: self.dataSource))
Severity: Minor
Found in waosSwift/modules/tasks/controllers/TasksListController.swift - About 1 hr to fix

    Function bindView has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        func bindView(_ reactor: TasksListReactor) {
            // tableview
            self.tableView.rx.setDelegate(self).disposed(by: self.disposeBag)
            self.dataSource.canEditRowAtIndexPath = { _, _  in true }
            // item selected
    Severity: Minor
    Found in waosSwift/modules/tasks/controllers/TasksListController.swift - About 1 hr to fix

      Identical blocks of code found in 10 locations. Consider refactoring.
      Open

              reactor.state
                  .map { $0.error }
                  .filterNil()
                  .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
                  .subscribe(onNext: { error in
      waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
      waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
      waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
      waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
      waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
      waosSwift/modules/users/controllers/UserController.swift on lines 536..546
      waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
      waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
      waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 155.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Wontfix

              self.rx.viewWillAppear
                  .throttle(.milliseconds(Metric.timesRefreshData), latest: false, scheduler: MainScheduler.instance)
                  .map { _ in Reactor.Action.get }
                  .bind(to: reactor.action)
                  .disposed(by: self.disposeBag)
      Severity: Major
      Found in waosSwift/modules/tasks/controllers/TasksListController.swift and 2 other locations - About 50 mins to fix
      waosSwift/modules/home/controllers/HomePageController.swift on lines 123..127
      waosSwift/modules/users/controllers/UserController.swift on lines 380..384

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              self.refreshControl.rx.controlEvent(.valueChanged)
                  .map { Reactor.Action.get }
                  .bind(to: reactor.action)
                  .disposed(by: self.disposeBag)
      Severity: Minor
      Found in waosSwift/modules/tasks/controllers/TasksListController.swift and 1 other location - About 30 mins to fix
      waosSwift/modules/users/controllers/UserController.swift on lines 386..389

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status