Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/tasks/controllers/TasksViewController.swift

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    func bindView(_ reactor: TasksViewReactor) {
        // cancel
        self.barButtonCancel.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 4 other locations - About 3 hrs to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 146..167
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 186..207
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 75..96
waosSwift/modules/users/controllers/UserViewController.swift on lines 198..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 10 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 9 other locations - About 2 hrs to fix
waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
waosSwift/modules/users/controllers/UserController.swift on lines 536..546
waosSwift/modules/users/controllers/UserMoreController.swift on lines 186..196
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

        reactor.state
            .map { $0.isDismissed }
            .distinctUntilChanged()
            .filter { $0 }
            .observe(on: MainScheduler.asyncInstance)
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 5 other locations - About 1 hr to fix
waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 207..215
waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 306..314
waosSwift/modules/users/controllers/UserMoreController.swift on lines 176..184
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 129..137
waosSwift/modules/users/controllers/UserViewController.swift on lines 435..443

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Wontfix

        self.barButtonDone.rx.tap
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .map { Reactor.Action.done }
            .bind(to: reactor.action)
            .disposed(by: self.disposeBag)
Severity: Major
Found in waosSwift/modules/tasks/controllers/TasksViewController.swift and 3 other locations - About 50 mins to fix
waosSwift/modules/home/controllers/HomeTermsController.swift on lines 83..87
waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 102..106
waosSwift/modules/users/controllers/UserViewController.swift on lines 225..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status