Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/users/controllers/UserMoreController.swift

Summary

Maintainability
A
3 hrs
Test Coverage

Function bindView has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Wontfix

    func bindView(_ reactor: UserMoreReactor) {
        // cancel
        self.barButtonClose.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Minor
Found in waosSwift/modules/users/controllers/UserMoreController.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bindView has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func bindView(_ reactor: UserMoreReactor) {
        // cancel
        self.barButtonClose.rx.tap
            .subscribe(onNext: { [weak self] _ in
                guard let `self` = self else { return }
Severity: Major
Found in waosSwift/modules/users/controllers/UserMoreController.swift - About 2 hrs to fix

    Identical blocks of code found in 10 locations. Consider refactoring.
    Open

            reactor.state
            .map { $0.error }
            .filterNil()
            .throttle(.milliseconds(Metric.timesButtonsThrottle), latest: false, scheduler: MainScheduler.instance)
            .subscribe(onNext: { error in
    Severity: Major
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 9 other locations - About 2 hrs to fix
    waosSwift/modules/auth/controllers/AuthSigninController.swift on lines 307..317
    waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 360..370
    waosSwift/modules/home/controllers/HomePageController.swift on lines 153..163
    waosSwift/modules/home/controllers/HomeTermsController.swift on lines 130..140
    waosSwift/modules/tasks/controllers/TasksListController.swift on lines 205..215
    waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 141..151
    waosSwift/modules/users/controllers/UserController.swift on lines 536..546
    waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 139..149
    waosSwift/modules/users/controllers/UserViewController.swift on lines 460..470

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 155.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Wontfix

            self.buttonLegalNotice.rx.tap
            .subscribe(onNext: { _ in
                if (L10n.linksLegal.prefix(4) == "http") {
                    guard let url = URL(string: L10n.linksLegal) else { return }
                    let svc = SFSafariViewController(url: url)
    Severity: Major
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 3 other locations - About 2 hrs to fix
    waosSwift/modules/users/controllers/UserController.swift on lines 238..250
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 113..125
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 126..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 146.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Wontfix

            self.buttonPrivacyPolicy.rx.tap
            .subscribe(onNext: { _ in
                if (L10n.linksPrivacy.prefix(4) == "http") {
                    guard let url = URL(string: L10n.linksPrivacy) else { return }
                    let svc = SFSafariViewController(url: url)
    Severity: Major
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 3 other locations - About 2 hrs to fix
    waosSwift/modules/users/controllers/UserController.swift on lines 238..250
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 113..125
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 139..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 146.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Wontfix

            self.buttonTermsOfUse.rx.tap
            .subscribe(onNext: { _ in
                if (L10n.linksTerms.prefix(4) == "http") {
                    guard let url = URL(string: L10n.linksTerms) else { return }
                    let svc = SFSafariViewController(url: url)
    Severity: Major
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 3 other locations - About 2 hrs to fix
    waosSwift/modules/users/controllers/UserController.swift on lines 238..250
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 126..138
    waosSwift/modules/users/controllers/UserMoreController.swift on lines 139..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 146.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

            reactor.state
            .map { $0.isDismissed }
            .distinctUntilChanged()
            .filter { $0 }
            .observe(on: MainScheduler.asyncInstance)
    Severity: Major
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 5 other locations - About 1 hr to fix
    waosSwift/modules/auth/controllers/AuthForgotController.swift on lines 207..215
    waosSwift/modules/auth/controllers/AuthSignupController.swift on lines 306..314
    waosSwift/modules/tasks/controllers/TasksViewController.swift on lines 131..139
    waosSwift/modules/users/controllers/UserPreferenceController.swift on lines 129..137
    waosSwift/modules/users/controllers/UserViewController.swift on lines 435..443

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

            self.buttonChangelog.rx.tap
            .subscribe(onNext: { _ in
                let viewController = HomePageController(reactor: reactor.changelogReactor())
                let navigationController = UINavigationController(rootViewController: viewController)
                self.present(navigationController, animated: true, completion: nil)
    Severity: Minor
    Found in waosSwift/modules/users/controllers/UserMoreController.swift and 1 other location - About 1 hr to fix
    waosSwift/modules/users/controllers/UserController.swift on lines 251..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status