Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/users/reactors/UserReactor.swift

Summary

Maintainability
A
0 mins
Test Coverage

Function mutate has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // refresh
        case let .refresh(user):
            log.verbose("♻️ Action -> Mutation : refresh")
Severity: Minor
Found in waosSwift/modules/users/reactors/UserReactor.swift - About 1 hr to fix

    Function mutate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // refresh
        case let .refresh(user):
            log.verbose("♻️ Action -> Mutation : refresh")
    Severity: Minor
    Found in waosSwift/modules/users/reactors/UserReactor.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Wontfix

                return self.provider.userService
                .data()
                .map { result in
                    switch result {
                    case .success:
    Severity: Major
    Found in waosSwift/modules/users/reactors/UserReactor.swift - About 30 mins to fix

      Avoid too many return statements within this function.
      Wontfix

                              return .success("delete")
      Severity: Major
      Found in waosSwift/modules/users/reactors/UserReactor.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Wontfix

                    return self.provider.userService
                .delete()
                .map { result in
                    switch result {
                    case .success:
        Severity: Major
        Found in waosSwift/modules/users/reactors/UserReactor.swift - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Wontfix

          /**
 * Dependencies
 */

import ReactorKit
          Severity: Major
          Found in waosSwift/modules/users/reactors/UserReactor.swift and 1 other location - About 2 hrs to fix
          waosSwift/modules/tasks/reactors/TasksListReactor.swift on lines 1..248

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 139.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Wontfix

              func transform(action: Observable<Action>) -> Observable<Action> {
        let refresh = self.provider.userService.user
            .filterNil()
            .distinctUntilChanged()
            .map { Action.refresh($0) }
          Severity: Major
          Found in waosSwift/modules/users/reactors/UserReactor.swift and 1 other location - About 1 hr to fix
          waosSwift/modules/tasks/reactors/TasksListReactor.swift on lines 86..92

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Wontfix

                      return self.provider.userService
                .data()
                .map { result in
                    switch result {
                    case .success:
          Severity: Minor
          Found in waosSwift/modules/users/reactors/UserReactor.swift and 1 other location - About 50 mins to fix
          waosSwift/modules/users/reactors/UserViewReactor.swift on lines 146..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Wontfix

              func pageReactor(name: String) -> HomePageReactor {
        return HomePageReactor(provider: self.provider, api: .page(name), style: .classic, displayLinks: true)
    }
          Severity: Minor
          Found in waosSwift/modules/users/reactors/UserReactor.swift and 1 other location - About 35 mins to fix
          waosSwift/modules/users/reactors/UserMoreReactor.swift on lines 83..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status