Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/users/reactors/UserViewReactor.swift

Summary

Maintainability
A
0 mins
Test Coverage

Function reduce has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Wontfix

    func reduce(state: State, mutation: Mutation) -> State {
        var state = state
        switch mutation {
        // inputs
        case let .updateFirstName(firstName):
Severity: Minor
Found in waosSwift/modules/users/reactors/UserViewReactor.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mutate has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // inputs
        case let .updateFirstName(firstName):
            return .just(.updateFirstName(firstName))
Severity: Major
Found in waosSwift/modules/users/reactors/UserViewReactor.swift - About 3 hrs to fix

    Function mutate has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        // inputs
        case let .updateFirstName(firstName):
            return .just(.updateFirstName(firstName))
    Severity: Minor
    Found in waosSwift/modules/users/reactors/UserViewReactor.swift - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reduce has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        func reduce(state: State, mutation: Mutation) -> State {
        var state = state
        switch mutation {
        // inputs
        case let .updateFirstName(firstName):
    Severity: Major
    Found in waosSwift/modules/users/reactors/UserViewReactor.swift - About 2 hrs to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Wontfix

      /**
 * Dependencies
 */

import UIKit
      Severity: Major
      Found in waosSwift/modules/users/reactors/UserViewReactor.swift and 3 other locations - About 1 hr to fix
      waosSwift/modules/auth/reactors/AuthForgotReactor.swift on lines 1..157
      waosSwift/modules/auth/reactors/AuthSigninReactor.swift on lines 1..188
      waosSwift/modules/auth/reactors/AuthSignupReactor.swift on lines 1..210

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                      self.provider.userService
                    .deleteAvatar()
                    .map { result in
                        switch result {
                        case .success: return .success("avatar deleted")
      Severity: Minor
      Found in waosSwift/modules/users/reactors/UserViewReactor.swift and 1 other location - About 50 mins to fix
      waosSwift/modules/users/reactors/UserReactor.swift on lines 117..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status