Sign upLogin

weareopensource/Swift

View on GitHub
Star
waosSwift/modules/users/services/UserService.swift

Summary

Maintainability
A
3 hrs
Test Coverage

Function updateDeviceToken has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Wontfix

    func updateDeviceToken(_ deviceToken: String) {
        self.networking.request(.me) { result in
            switch result {
            case let .success(moyaResponse):
                do {
Severity: Minor
Found in waosSwift/modules/users/services/UserService.swift - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateDeviceToken has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    func updateDeviceToken(_ deviceToken: String) {
        self.networking.request(.me) { result in
            switch result {
            case let .success(moyaResponse):
                do {
Severity: Minor
Found in waosSwift/modules/users/services/UserService.swift - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Wontfix

                                    if user.data.complementary?.iosDevices![index].swift != UIDevice.current.systemVersion {
                                    user.data.complementary?.iosDevices![index].swift = UIDevice.current.systemVersion
                                    shouldUpdate = true
                                }
    Severity: Major
    Found in waosSwift/modules/users/services/UserService.swift - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          func deleteAvatar() -> Observable<MyResult<UserResponse, CustomError>> {
        log.verbose("🔌 service : delete avatar ")
        return self.networking
            .request(.deleteAvatar)
            .map(UserResponse.self)
      Severity: Major
      Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
      waosSwift/modules/users/services/UserService.swift on lines 35..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          func me() -> Observable<MyResult<UserResponse, CustomError>> {
        log.verbose("🔌 service : me")
        return self.networking
            .request(.me)
            .map(UserResponse.self)
      Severity: Major
      Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
      waosSwift/modules/users/services/UserService.swift on lines 104..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          func data() -> Observable<MyResult<MailResponse, CustomError>> {
        log.verbose("🔌 service : data")
        return self.networking
            .request(.data)
            .map(MailResponse.self)
      Severity: Major
      Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
      waosSwift/modules/users/services/UserService.swift on lines 63..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          func terms() -> Observable<MyResult<UserResponse, CustomError>> {
        log.verbose("🔌 service : me")
        return self.networking
            .request(.terms)
            .map(UserResponse.self)
      Severity: Major
      Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 1 hr to fix
      waosSwift/modules/users/services/UserService.swift on lines 118..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

      /**
 * Controller
 */

import UIKit
      Severity: Minor
      Found in waosSwift/modules/users/services/UserService.swift and 1 other location - About 45 mins to fix
      waosSwift/modules/auth/services/AuthService.swift on lines 1..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status