Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java

Summary

Maintainability
D
3 days
Test Coverage

File DOM.java has 663 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2014-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
Severity: Major
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 1 day to fix

    Method getBoxModel has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @ChromeDevtoolsMethod
  public GetBoxModelResponse getBoxModel(JsonRpcPeer peer, JSONObject params) {
    GetBoxModelResponse response = new GetBoxModelResponse();
    final BoxModel model = new BoxModel();
    final GetBoxModelRequest request = mObjectMapper.convertValue(
    Severity: Major
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 5 hrs to fix

      DOM has 31 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class DOM implements ChromeDevtoolsDomain {
  private static boolean sNativeMode = true;
  private final ObjectMapper mObjectMapper;
  private final Document mDocument;
  private final Map<String, List<Integer>> mSearchResults;
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 3 hrs to fix

        Method onChildNodeInserted has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                DocumentView view,
        Object element,
        int parentNodeId,
        int previousNodeId,
        Accumulator<Object> insertedElements) {
        Severity: Minor
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 35 mins to fix

          Method getColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public int getColor() {
      byte alpha;
      if (this.a == null) {
        alpha = (byte) 255;
      } else {
          Severity: Minor
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            private static class BoxModel {
    @JsonProperty(required = true)
    public List<Double> content;
    @JsonProperty(required = true)
    public List<Double> padding;
          Severity: Major
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java and 2 other locations - About 1 hr to fix
          inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java on lines 141..159
          inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Page.java on lines 375..388

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            private ChildNodeInsertedEvent acquireChildNodeInsertedEvent() {
    ChildNodeInsertedEvent childNodeInsertedEvent = mCachedChildNodeInsertedEvent;
    if (childNodeInsertedEvent == null) {
      childNodeInsertedEvent = new ChildNodeInsertedEvent();
    }
          Severity: Major
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java and 4 other locations - About 30 mins to fix
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java on lines 320..330
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java on lines 340..347
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/ShadowDocument.java on lines 246..253
          inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java on lines 537..544

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            private ChildNodeRemovedEvent acquireChildNodeRemovedEvent() {
    ChildNodeRemovedEvent childNodeRemovedEvent = mCachedChildNodeRemovedEvent;
    if (childNodeRemovedEvent == null) {
      childNodeRemovedEvent = new ChildNodeRemovedEvent();
    }
          Severity: Major
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java and 4 other locations - About 30 mins to fix
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java on lines 320..330
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java on lines 340..347
          inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/ShadowDocument.java on lines 246..253
          inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java on lines 519..526

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status