weexteam/weex_devtools_android

View on GitHub

Showing 2,519 of 2,519 total issues

Function has a complexity of 7.
Open

                      this.toString = function () {

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Method setImage has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  @Override
  public void setImage(final String url, final ImageView view,
                       WXImageQuality quality, final WXImageStrategy strategy) {

    WXSDKManager.getInstance().postOnUiThread(new Runnable() {

    Function 0 has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    /***/ function(module, exports, __webpack_require__) {
    
        ;__weex_define__("@weex-component/8e6cff2d0487efb24411ddaeb27766c3", [], function(__weex_require__, __weex_exports__, __weex_module__){
    
        ;
    Severity: Minor
    Found in playground/app/src/main/assets/syntax/script-component.js - About 1 hr to fix

      Method testTextStyleColumn has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public void testTextStyleColumn(){
      
              for(final View caseView : mCaseListIndexView){
                  String caseViewText = new String("");
                  caseViewText = ((WXTextView)caseView).getText().toString();

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method testTextStyleRow has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public void testTextStyleRow(){
      
              for(final View caseView : mCaseListIndexView){
                 if (((WXTextView)caseView).getText().toString().equals("TC_Text")){
                     Log.e(TAG, "TC_Text find");

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method flush has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        public void flush() throws IOException {
          //Log.i("PackageManager", "flush mPos=" + mPos);
          if (mPos > 0) {
            if (mOutputStream != null) {
              CharBuffer charBuffer = CharBuffer.wrap(mText, 0, mPos);

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method execJSWithResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public byte[] execJSWithResult(String instanceId, String namespace, String function, WXJSObject[] args) {
      
              String result = "";
      
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method syncCall has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @ChromeDevtoolsMethod
          public SyncCallResponse syncCall(JsonRpcPeer peer, JSONObject params) {
              WXLogUtils.e("WxDebug-new >>>> syncCall=" + params);
              SyncCallResponse response = new SyncCallResponse();
              int syncId = params.optInt("syncId");

        Method getValueForField has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private Object getValueForField(Field field, Object value)
              throws JSONException {
            try {
              if (value != null) {
                if (value == JSONObject.NULL) {

          Method onBindViewHolder has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
              public void onBindViewHolder(final ItemHolder holder, int position) {
                final WXTracing.TraceEvent event = rootEvent.subEvents.valueAt(position);
                holder.itemView.setOnClickListener(new View.OnClickListener() {
                  @Override

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setElementParent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private void setElementParent(Object element, Object parentElement) {
                ElementInfo changesElementInfo = mElementToInfoChangesMap.get(element);
                if (changesElementInfo != null &&
                    parentElement == changesElementInfo.parentElement) {
                  return;

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _convertToJSONObject has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            private JSONObject _convertToJSONObject(Object fromValue)
                throws JSONException, InvocationTargetException, IllegalAccessException {
              JSONObject jsonObject = new JSONObject();
          
              if(fromValue instanceof Map) {

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                         if(inputListView.size()!=0){
                            final WXTextView inputTypeView = (WXTextView)inputListView.get(0);
                             Log.e(TAG, "inputTypeView text == " +inputTypeView.getText().toString());
          
                             mInstrumentation.runOnMainSync(new Runnable() {
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 131..152
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 156..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                         if(inputListView.size()!=0){
                             final WXTextView inputTypeView = (WXTextView)inputListView.get(0);
                             Log.e(TAG, "inputTypeView text == " +inputTypeView.getText().toString());
          
                             mInstrumentation.runOnMainSync(new Runnable() {
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 101..120
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 131..152

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                         if(inputListView.size()!=0){
                             final WXTextView inputTypeView = (WXTextView)inputListView.get(0);
                             Log.e(TAG, "inputTypeView text == " +inputTypeView.getText().toString());
          
                             mInstrumentation.runOnMainSync(new Runnable() {
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 101..120
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Image/WeexUiTestCaseTcImageUpdate.java on lines 156..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public ArrayList<View> getTestCaseListViewByText(String byText) throws InterruptedException {
                  Log.e("TestScript_Guide", "byText ==" + byText);
          
                  if(TextUtils.isEmpty(byText)){
                      return null;
          playground/app/src/androidTest/java/com/alibaba/weex/uitest/TC_Color/WeexUiTestCaseTcColorType.java on lines 136..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public ArrayList<View> getTestCaseListViewByText(String byText) throws InterruptedException {
                  Log.e("TestScript_Guide", "byText ==" + byText);
          
                  if(TextUtils.isEmpty(byText)){
                      return null;
          playground/app/src/androidTest/java/com/alibaba/weex/pertest/WeexPerTestCaseListPerfWithAppendTree.java on lines 136..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function 18 has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          /***/ function(module, exports) {
          
              ;__weex_define__("@weex-component/banner", [], function(__weex_require__, __weex_exports__, __weex_module__){
          
              ;
          Severity: Minor
          Found in playground/app/src/main/assets/showcase/new-fashion/resource.js - About 1 hr to fix

            Function 18 has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            /***/ function(module, exports) {
            
                ;__weex_define__("@weex-component/banner", [], function(__weex_require__, __weex_exports__, __weex_module__){
            
                ;
            Severity: Minor
            Found in playground/app/src/main/assets/showcase/new-fashion/goods.js - About 1 hr to fix

              Function 18 has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              /***/ function(module, exports) {
              
                  ;__weex_define__("@weex-component/banner", [], function(__weex_require__, __weex_exports__, __weex_module__){
              
                  ;
              Severity: Minor
              Found in playground/app/src/main/assets/showcase/new-fashion/fashion.js - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language