weexteam/weex_devtools_android

View on GitHub

Showing 2,519 of 2,519 total issues

Method getViewProperties has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private List<ViewCSSProperty> getViewProperties() {
    if (mViewProperties == null) {
      synchronized (this) {
        if (mViewProperties == null) {
          List<ViewCSSProperty> props = new ArrayList<>();

    Method onCreateView has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @Override
      public View onCreateView(LayoutInflater inflater, ViewGroup container,
                               Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        rootView = inflater.inflate(R.layout.fragment_js_log, container, false);

      Function created has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              created: function() {
                var bundleUrl = this.$getConfig().bundleUrl;
                console.log('hit', bundleUrl);
                var dirs = this.root.split('/');
                dirs.forEach(function(dir, index) {
      Severity: Minor
      Found in playground/app/src/main/assets/syntax/index.js - About 1 hr to fix

        Function created has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                created: function() {
                  var bundleUrl = this.$getConfig().bundleUrl;
                  console.log('hit', bundleUrl);
                  var dirs = this.root.split('/');
                  dirs.forEach(function(dir, index) {
        Severity: Minor
        Found in playground/app/src/main/assets/index.js - About 1 hr to fix

          Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void testDowngrade(){
          
                  for(final View caseView : mCaseListIndexView){
                     if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                         Log.e(TAG, "TC_Downgrade find");

            Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void testDowngrade(){
            
                    for(final View caseView : mCaseListIndexView){
                       if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                           Log.e(TAG, "TC_Downgrade find");

              Method testTextType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void testTextType(){
              
                      for(final View caseView : mCaseListIndexView){
                         if (((WXTextView)caseView).getText().toString().equals("TC_Text")){
                             Log.e(TAG, "TC_Text find");

                Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void testDowngrade(){
                
                        for(final View caseView : mCaseListIndexView){
                           if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                               Log.e(TAG, "TC_Downgrade find");

                  Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public void testDowngrade(){
                  
                          for(final View caseView : mCaseListIndexView){
                             if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                                 Log.e(TAG, "TC_Downgrade find");

                    Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public void testDowngrade(){
                    
                            for(final View caseView : mCaseListIndexView){
                               if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                                   Log.e(TAG, "TC_Downgrade find");

                      Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public void testDowngrade(){
                      
                              for(final View caseView : mCaseListIndexView){
                                 if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                                     Log.e(TAG, "TC_Downgrade find");

                        Method testDowngrade has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public void testDowngrade(){
                        
                                for(final View caseView : mCaseListIndexView){
                                   if (((WXTextView)caseView).getText().toString().equals("TC_Downgrade")){
                                       Log.e(TAG, "TC_Downgrade find");

                          Method responseHeadersReceived has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            @Override
                            public void responseHeadersReceived(InspectorResponse response) {
                              NetworkPeerManager peerManager = getPeerManagerIfEnabled();
                              if (peerManager != null) {
                                Network.Response responseJSON = new Network.Response();

                            Method Slider has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public  void Slider(){
                            
                                    for(final View caseView : mCaseListIndexView){
                                        if (((WXTextView)caseView).getText().toString().equals("TC_Slider")){
                                            Log.e(TAG, "TC_Slider find");

                              Function data has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      data: function () {return {
                                        appearMin:1,
                                        appearMax:1,
                                        appearIds:[],
                                        rows:[
                              Severity: Minor
                              Found in playground/app/src/main/assets/component/list/list-basic.js - About 1 hr to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  private void move(int x, int y) {
                                    final Activity activity = ActivityTracker.get().tryGetTopActivity();
                                    if (activity != null) {
                                      final MotionEvent move = MotionEvent.obtain(
                                          downTime, System.currentTimeMillis(),
                                inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Input.java on lines 165..181

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 96.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  private void up(int x, int y) {
                                    final Activity activity = ActivityTracker.get().tryGetTopActivity();
                                    if (activity != null) {
                                      final MotionEvent up = MotionEvent.obtain(
                                          downTime, System.currentTimeMillis(),
                                inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Input.java on lines 128..144

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 96.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Method intercept has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    @Override
                                    public Response intercept(Chain chain) throws IOException {
                                        String requestId = String.valueOf(mNextRequestId.getAndIncrement());
                                
                                        Request request = chain.request();

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method intercept has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    @Override
                                    public Response intercept(Chain chain) throws IOException {
                                        String requestId = String.valueOf(mNextRequestId.getAndIncrement());
                                
                                        Request request = chain.request();

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method onGetChildren has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  @Override
                                  protected void onGetChildren(AndroidDocumentRoot element, Accumulator<Object> children) {
                                    if (DOM.isNativeMode()) {
                                      children.store(mApplication);
                                    } else {

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language