Sign upLogin

weexteam/weex_devtools_android

View on GitHub
Star

Showing 2,519 of 2,519 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public static class DataReceivedParams {
    @JsonProperty(required = true)
    public String requestId;

    @JsonProperty(required = true)
Severity: Major
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java and 2 other locations - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/CSS.java on lines 237..249
inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/Network.java on lines 335..347

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  private void abort(String message, Throwable cause) {
    Log.w(TAG, "Error occurred, shutting down websocket connection: " + message);
    close();

    // Trigger failure callbacks
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttp3SocketClient.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttpSocketClient.java on lines 185..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  private void abort(String message, Throwable cause) {
    Log.w(TAG, "Error occurred, shutting down websocket connection: " + message);
    close();
    // Trigger failure callbacks
    if (mConnectCallback != null) {
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttpSocketClient.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttp3SocketClient.java on lines 192..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      } else if ("onPong".equals(method.getName())) {

      } else if ("onClose".equals(method.getName())) {
        if (mHandlerThread != null && mHandlerThread.isAlive()) {
          mHandler.sendEmptyMessage(CLOSE_WEB_SOCKET);
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttp3SocketClient.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttpSocketClient.java on lines 221..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      } else if ("onPong".equals(method.getName())) {

      } else if ("onClose".equals(method.getName())) {
        if (mHandlerThread != null && mHandlerThread.isAlive()) {
          mHandler.sendEmptyMessage(CLOSE_WEB_SOCKET);
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttpSocketClient.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/debug/OkHttp3SocketClient.java on lines 231..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  private final class MethodBackedCSSProperty extends ViewCSSProperty {
    private final Method mMethod;

    public MethodBackedCSSProperty(
        Method method,
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java on lines 417..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (messageNode.has("method")) {
            handleRemoteRequest(peer, messageNode);
        } else if (messageNode.has("result")) {
            handleRemoteResponse(peer, messageNode);
        } else {
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/debug/DebugServerProxy.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java on lines 111..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  private final class FieldBackedCSSProperty extends ViewCSSProperty {
    private final Field mField;

    public FieldBackedCSSProperty(
        Field field,
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java on lines 435..451

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (messageNode.has("method")) {
      handleRemoteRequest(peer, messageNode);
    } else if (messageNode.has("result")) {
      handleRemoteResponse(peer, messageNode);
    } else {
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/ChromeDevtoolsServer.java and 1 other location - About 40 mins to fix
inspector/src/main/java/com/taobao/weex/devtools/debug/DebugServerProxy.java on lines 223..229

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method onChildNodeInserted has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        DocumentView view,
        Object element,
        int parentNodeId,
        int previousNodeId,
        Accumulator<Object> insertedItems) {
Severity: Minor
Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java - About 35 mins to fix

    Method getStyleFromValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          View element,
      String name,
      Object value,
      @Nullable ViewDebug.ExportedProperty annotation,
      StyleAccumulator styles) {
    Severity: Minor
    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java - About 35 mins to fix

      Method findMatches has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        private void findMatches(Object element, int x, int y, Accumulator<Integer> matchedIds, Boolean found) {
      Severity: Minor
      Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java - About 35 mins to fix

        Method onChildNodeInserted has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                DocumentView view,
        Object element,
        int parentNodeId,
        int previousNodeId,
        Accumulator<Object> insertedItems);
        Severity: Minor
        Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/Document.java - About 35 mins to fix

          Method getStylesFromObject has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                View view,
      String name,
      Object value,
      @Nullable ViewDebug.ExportedProperty annotation,
      StyleAccumulator styles) {
          Severity: Minor
          Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/elements/android/ViewDescriptor.java - About 35 mins to fix

            Method hitTestImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  View view,
      float x,
      float y,
      @Nullable Predicate<View> viewSelector,
      boolean allowViewGroupResult) {
            Severity: Minor
            Found in inspector/src/main/java/com/taobao/weex/devtools/common/android/ViewUtil.java - About 35 mins to fix

              Method isTransformedPointInView has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    ViewGroup parent,
      View child,
      float x,
      float y,
      @Nullable PointF outLocalPoint) {
              Severity: Minor
              Found in inspector/src/main/java/com/taobao/weex/devtools/common/android/ViewUtil.java - About 35 mins to fix

                Method interpretResponseStream has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      String requestId,
      @Nullable String contentType,
      @Nullable String contentEncoding,
      @Nullable InputStream availableInputStream,
      ResponseHandler responseHandler) {
                Severity: Minor
                Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/network/NetworkEventReporterImpl.java - About 35 mins to fix

                  Method callNativeModule has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    public native void callNativeModule(String instanceId, String module, String method, byte[]
      arguments, byte[] options);
                  Severity: Minor
                  Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/JsBridgeCall.java - About 35 mins to fix

                    Method onChildNodeInserted has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            DocumentView view,
        Object element,
        int parentNodeId,
        int previousNodeId,
        Accumulator<Object> insertedElements) {
                    Severity: Minor
                    Found in inspector/src/main/java/com/taobao/weex/devtools/inspector/protocol/module/DOM.java - About 35 mins to fix

                      Method callNativeModule has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public Object callNativeModule(String instanceId, String module, String method, byte[] arguments, byte[] options) {
                      Severity: Minor
                      Found in inspector/src/main/java/com/taobao/weex/devtools/debug/WXDebugBridge.java - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language